-
Notifications
You must be signed in to change notification settings - Fork 72
Conversation
I'm wondering if we should add Node 4.x to the build matrix maybe (for our Node libraries)? (so we don't necessarily have to rely on user reports) /cc @zcbenz @atom/feedback |
|
Sounds good to me. |
Not sure where to proceed from here...Clang actually seems to be segfaulting when running under Node 4. There's also a lot of failures related to temp files. |
@50Wliu segfaults may gone after |
Once I get atom/node-pathwatcher#90 all set up and merged, then I'll rebase/update this PR accordingly. |
Conflicts: package.json
Tests continue to fail but the install no longer segfaults. |
Ok so I've fixed most of the errors by simply updating
|
It seems that |
@zcbenz I think this is due to a |
@maxbrunsfeld Thanks! For the rest of the failing specs, it is actually caused by switching to Linux in Travis CI, it seems that they never passed on Linux in previous versions. I'm going to suppress those specs for now so we can focus on updating to latest Electron in Atom. |
Should allow text-buffer to compile on Node 4.
Closes #98