-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
@zcbenz can you look at the npm install errors by any chance? Thanks. |
I think it is a bug of clang, we can use g++ >= 4.8 in CI to work around it. |
@zcbenz Unless I'm doing something wrong, g++-4.8 doesn't exist on Travis. |
It needs to be installed from PPA, an example can be found at: And we also need to use GCC 4.8 for modules that depend on this module. |
Ok, the build's passing again, so that's 💚. Now the only thing left I think is that make keeps failing on the first pass with:
but then succeeds on the second try. |
Looks good to me, thanks! |
Switch travis.yml to use nodejs
@zcbenz thanks so much for the help ✨! |
I think it is fine to ignore that for now, if it still happens in future we can report it to NAN's repo. |
Just investigating if pathwatcher actually builds on Node 4.
Refs atom/text-buffer#99.