Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Switch travis.yml to use nodejs #90

Merged
merged 6 commits into from
Sep 18, 2015
Merged

Switch travis.yml to use nodejs #90

merged 6 commits into from
Sep 18, 2015

Conversation

winstliu
Copy link
Contributor

Just investigating if pathwatcher actually builds on Node 4.
Refs atom/text-buffer#99.

@winstliu
Copy link
Contributor Author

@zcbenz can you look at the npm install errors by any chance? Thanks.

@zcbenz
Copy link
Contributor

zcbenz commented Sep 16, 2015

I think it is a bug of clang, we can use g++ >= 4.8 in CI to work around it.

@winstliu
Copy link
Contributor Author

@zcbenz Unless I'm doing something wrong, g++-4.8 doesn't exist on Travis.

@zcbenz
Copy link
Contributor

zcbenz commented Sep 17, 2015

It needs to be installed from PPA, an example can be found at:
https://github.com/atom/node-oniguruma/blob/master/.travis.yml

And we also need to use GCC 4.8 for modules that depend on this module.

@winstliu
Copy link
Contributor Author

Ok, the build's passing again, so that's 💚. Now the only thing left I think is that make keeps failing on the first pass with:

make: Entering directory `/home/travis/build/atom/node-pathwatcher/node_modules/runas/build'
  CXX(target) Release/obj.target/runas/src/main.o
In file included from ../src/main.cc:1:0:
../../nan/nan.h:138:53: fatal error: nan_callbacks.h: No such file or directory
 #include "nan_callbacks.h"  // NOLINT(build/include)

but then succeeds on the second try.

@zcbenz
Copy link
Contributor

zcbenz commented Sep 18, 2015

Looks good to me, thanks!

zcbenz added a commit that referenced this pull request Sep 18, 2015
Switch travis.yml to use nodejs
@zcbenz zcbenz merged commit cfb121a into master Sep 18, 2015
@zcbenz zcbenz deleted the travis-node-js branch September 18, 2015 03:41
@winstliu
Copy link
Contributor Author

@zcbenz thanks so much for the help ✨!
Though do you think the error above needs addressing or that it's fine?

@zcbenz
Copy link
Contributor

zcbenz commented Sep 18, 2015

I think it is fine to ignore that for now, if it still happens in future we can report it to NAN's repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants