Added Javascript interpolated template string syntax coloring

[cmbankester]

• Color template string interpolation punctuation red
• Unset string color for contents of template string interpolation

[schmty]

Could you show some before and after screenshots?

[cmbankester]

Before:

After:

[cmbankester]

Looks like I made a mistake with the selector:

(the ending semicolon and function-body closing bracket are red).

I'll fix that as soon as I can.

[schmty]

@cbankester alright. Looks good! Once you fix this ping me and we will get this pulled in 👍

[cmbankester]

I fixed the selector issue, but uncovered a bug in atom/language-javascript that causes the closing bracket of a non-empty function body inside template string interpolation to be marked-up as the closing bracket of the interpolation. See, e.g.:

I'll be opening an issue or pull request on that package soon, but as far as I'm aware, the styles here are correct now.

[schmty]

Nice work @cbankester I will say that I would probably prefer for the language-javascript issue to be resolved first though

[cmbankester]

Agreed. I poked around their source, but it's quite convoluted. I'll keep y'all updated on if a fix lands.

[schmty]

Awesome. Looking forward to getting this pulled in!

[schmty]

@cbankester I have filed an issue on the atom/language-javascript repo.
atom/language-javascript#199

[schmty]

@cbankester atom/language-javascript#199 has been resolved. I will take care of merging this in now! 👍

[nstepien]

@schmittyjd @cmbankester
Looks like it regressed at some point.

Nevermind it's just that atom hasn't published solarized v0.40