template string bracket mismatch

[schmty]

Hey atom peeps. In the solarized dark repo we have a cool pull request that will be adding cool template string coloring for javascript see here and there was a bug uncovered showing that template strings do not match up closing brackets properly.

For ex:

in our case, the open bracket color is dark blue (which is correct) and the closing bracket is cyan, the closing bracket should be red and the bracket closing the function should be blue and not cyan. Would love to help out with this but I am a tad unfamiliar with how the language packages actually work. If anyone could help on this let me know! Thanks

[Victorystick]

Since the regexes used to mark the code with scopes can't have internal state (eg. a counter for the number of left brackets found), it can't know when it has found the right number of matching brackets.

If language-javascript was to use a JavaScript parser, like acorn, this and other similar issues could be fixed. But just using regexes, I don't think it can. At least not in the general case.

[cmbankester]

@Victorystick Do you know of any plans to switch to a more fully-featured JS parser? This seems like a pretty big issue.

[winstliu]

@cbankester all Atom languages to my knowledge, and all 'official' ones, currently use a regex-based system.

[Victorystick]

I know of one Atom package, TypeStrong/atom-typescript, that initially used a code driven approach to mark scopes, but it has since switched back to the regex grammars.

[winstliu]

For easy copy/paste into Atom for testing:

`foo${function(){return the_stuff;}}`
`foo${() => {return the_stuff;}}`

My syntax theme is also highlighting this wrong, it might just be a JS issue and not bracket-matcher. Will keep investigating.

[schmty]

any updates on this?

[winstliu]

I've been busy but I'll try to take a look at this this week.

[MethodGrab]

I don't know if this will help but language-babel highlights the brackets correctly so you might be able to use it's patterns: