This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fixed so namespaces syntax works on same lime as <?php #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some specs to this. |
|
Added test for namespace on same line and on a separate line. |
| @@ -721,9 +721,9 @@ | |||
| ] | |||
| } | |||
| { | |||
| 'begin': '(?i)^\\s*(namespace)\\b\\s+(?=([a-z0-9_\\\\]+\\s*($|[;{]|(\\/[\\/*])))|$)' | |||
| 'begin': '(?i)(^\\s*|\\s)(namespace)\\b\\s+(?=([a-z0-9_\\\\]+\\s*($|[;{]|(\\/[\\/*])))|$)' | |||
There was a problem hiding this comment.
Shouldn't this be \\s* so that something like
<?php namespace superCoolNamespacewill work?
In addition, it looks like you can change that part to a non-capturing group, eg (?:^\\s*|\\s*) so that you don't have to change the capture group on L726.
There was a problem hiding this comment.
Changed to \\s* but it did work with \\s. Fixed so it's a non-capturing group.
…e-29 * 'issue-29' of github.com:frozzare/language-php: Fixed typo Added test for namespace on own line Added test for namespace on same line Fixed so namespaces syntax works on same lime as <?php
|
Looks like you accidentally included some changes from #72 into this PR-could you please remove them? |
|
Oops, sorry for that. Fixed now. |
winstliu
pushed a commit
that referenced
this pull request
May 14, 2015
Fixed so namespaces syntax works on same lime as <?php
|
Thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix #29