This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fixed default short array value syntax error #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the type array short value and added tests for both |
…ay() and short array when using array type
Fixed so namespaces syntax works on same lime as <?php
|
Looks like this pull request no longer merges cleanly, would you mind updating the conflicts via merging/rebasing master and then push up the changes? Thanks! |
…ay() and short array when using array type
|
Fixed. |
| 'name': 'variable.other.php' | ||
| '4': | ||
| 'name': 'punctuation.definition.variable.php' | ||
| '5': |
There was a problem hiding this comment.
Should this capture group just not be included (or make it a non-capturing group)?
There was a problem hiding this comment.
It should not be included, since short array don't have array before [] I just leave it empty. It can be changed to (?:) but when removing the fifth row the = get the array type color. Should i change it to (?:)?
kevinsawicki
added a commit
that referenced
this pull request
May 15, 2015
Fixed default short array value syntax error
|
Thanks for fixing this 🌴 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix #64