This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Hide git and GitHub tab avatar alt text when offline #2425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Add CSS to hide the alt text for the avatar image in the Git tab when the network is not available.
Same problem as #1528, same solution as #2066. Thanks again @rkbhochalya 😄
Screenshot/Gif
Alternate Designs
I looked into a few other ways to provide custom fallback images so we could use a local "blank avatar" image when applicable. Too much effort for too little benefit, though.
Benefits
The git tab header's layout won't break when the alt text overflows out of the avatar image's bounds.
Possible Drawbacks
None.
Applicable Issues
Fixes #2410.
Release Notes