Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Hide git and GitHub tab avatar alt text when offline #2425

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

smashwilson
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Add CSS to hide the alt text for the avatar image in the Git tab when the network is not available.

Same problem as #1528, same solution as #2066. Thanks again @rkbhochalya 😄

Screenshot/Gif

non-loaded avatar

Alternate Designs

I looked into a few other ways to provide custom fallback images so we could use a local "blank avatar" image when applicable. Too much effort for too little benefit, though.

Benefits

The git tab header's layout won't break when the alt text overflows out of the avatar image's bounds.

Possible Drawbacks

None.

Applicable Issues

Fixes #2410.

Release Notes

  • The alt text on your avatar in the Git tab no longer overflows when you're offline.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2425 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
- Coverage   93.25%   93.07%   -0.18%     
==========================================
  Files         235      235              
  Lines       13163    13163              
  Branches     1889     1889              
==========================================
- Hits        12275    12252      -23     
- Misses        888      911      +23     
Impacted Files Coverage Δ
lib/shared/keytar-strategy.js 38.75% <0.00%> (-8.53%) ⬇️
lib/models/file-system-change-observer.js 88.00% <0.00%> (-8.00%) ⬇️
lib/git-temp-dir.js 96.77% <0.00%> (-3.23%) ⬇️
lib/git-prompt-server.js 97.29% <0.00%> (-2.71%) ⬇️
lib/helpers.js 86.41% <0.00%> (-1.24%) ⬇️
lib/git-shell-out-strategy.js 99.23% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41aaa3f...e2d7449. Read the comment docs.

@smashwilson smashwilson merged commit 600e9ba into master Apr 3, 2020
@smashwilson smashwilson deleted the avatar-overflow branch April 3, 2020 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git pane avatar overflowing when not connected to internet
1 participant