This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Hide alt text when committer's avatar fails to load #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves an empty space instead of showing committer's email address when Atom is started with no internet connection. Closes #1528
smashwilson
approved these changes
Apr 15, 2019
smashwilson
added a commit
that referenced
this pull request
May 8, 2019
Hide alt text when committer's avatar fails to load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When we start Atom with no internet connectivity, committer's email address is shown in the place of committer's avatar in recent comments list in Git pane, which overlaps git messages and makes them hard to read. I have hidden alt text setting text color to transparent and overflow to hidden for the image element. This leaves an empty box instead of showing committer's email address when avatar fails to load and doesn't make any visual change when avatar is visible.
Screenshot/Gif
Alternate Designs
Alternatively we can show a default avatar but I went for just hiding the alt text as it was easy to implement.
Benefits
Commits list no longer looks weird when Atom is started with no internet.
Possible Drawbacks
Nothing I can think of.
Applicable Issues
#1528
Metrics
N/A
Tests
N/A
Documentation
N/A
Release Notes
Fixed an issue where committer's email address is shown in the place of committer's avatar when Atom is started with no internet connection.