This repository was archived by the owner on Dec 15, 2022. It is now read-only.
support new reaction emoji from GitHub.com #1985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
GitHub.com now supports reaction emoji: 👀 and 🚀 . Therefore, we should make sure these new emoji render when viewing pull requests and issues within Atom.
Also, now we don't render anything if the emoji is unrecognized. Hooray for graceful degradation.
Screenshot/Gif
N/A
Alternate Designs
N/A
Benefits
Emoji make subtext into text and enable remote communication and brings empathy into the development process. Letting our users use more kinds of emoji enables more communication modes.
Possible Drawbacks
Can't think of any.
Applicable Issues
#1916
Metrics
N/A
Tests
Documentation
N/A
Release Notes
User Experience Research (Optional)
N/A