Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

support new reaction emoji from GitHub.com #1985

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

annthurium
Copy link

Description of the Change

GitHub.com now supports reaction emoji: 👀 and 🚀 . Therefore, we should make sure these new emoji render when viewing pull requests and issues within Atom.

Also, now we don't render anything if the emoji is unrecognized. Hooray for graceful degradation.

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Emoji make subtext into text and enable remote communication and brings empathy into the development process. Letting our users use more kinds of emoji enables more communication modes.

Possible Drawbacks

Can't think of any.

Applicable Issues

#1916

Metrics

N/A

Tests

  • Wrote unit tests for the new emoji, graceful degradation
  • Manually rendered the issue that describes this problem (so meta) to verify the new emoji show up.

Documentation

N/A

Release Notes

  • The GitHub package now supports new reaction emoji: 👀 and 🚀

User Experience Research (Optional)

N/A

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #1985 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
+ Coverage   92.12%   92.13%   +0.01%     
==========================================
  Files         188      188              
  Lines       10803    10806       +3     
  Branches     1581     1581              
==========================================
+ Hits         9952     9956       +4     
+ Misses        851      850       -1
Impacted Files Coverage Δ
lib/views/emoji-reactions-view.js 100% <100%> (ø) ⬆️
lib/models/operation-states.js 91.66% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4932227...e11e687. Read the comment docs.

@annthurium annthurium requested a review from a team February 26, 2019 19:38
Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Hell yeah

@annthurium annthurium merged commit e2bc2ca into master Feb 26, 2019
@annthurium annthurium deleted the tt-19-feb-emoji-support branch February 26, 2019 21:08
@vanessayuenn vanessayuenn mentioned this pull request Mar 6, 2019
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants