This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Support new reaction emoji #1916
Closed
Description
Prerequisites
- Have you tried to reproduce the problem in Safe Mode?
- Have you followed all applicable steps in the debugging guide?
- Have you checked the FAQs on the message board for common solutions?
- Have you checked that your issue isn't already filed?
Description
GitHub.com shipped additional reaction emoji. We should support rendering these in our pull request detail item.
Steps to Reproduce
- Open a pull request detail open on a pull request or issue that includes a 🚀 or 👀 reaction emoji.
Expected behavior:
The 🚀 and 👀 emoji should appear like the others do.
Actual behavior:
Reproduces how often:
100%
Versions
atom/github 0.24.0
Additional Information
Here's the source code we need to add additional members to:
github/lib/views/emoji-reactions-view.js
Lines 5 to 12 in b509125
While we're in there, we should ensure we gracefully skip unrecognized emoji.