Skip to content

Update character literal matches to support ''' #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jan 25, 2016

This PR updates the character literal end capture regex with a negative lookahead for an single quote character to avoid capturing an single quote as the character literal (i.e. val c = '''. This is the same method by which #32 was fixed.

The matcher for a too-long character also had to be updated to correctly show an error for several single quotes in a row val c = ''''. There were two matchers for too-long char literals, and I replaced them with one generic matcher. It looks like it's working to me (catches several characters inside the single quotes, doesn't mark escaped or unicode chars as errors).

@gangstead could you sanity check this change for me? I've also not done a release for this package before (I'm familiar with the process after following the thread in #33), but if you'd rather handle it that would be cool.

gangstead added a commit that referenced this pull request Jan 25, 2016
Update character literal matches to support '''
@gangstead gangstead merged commit 9e8177c into master Jan 25, 2016
@gangstead
Copy link
Contributor

LGTM. After I goofed it up so bad last time I think it's better if you take a swing at publishing it. Remember to publish with apm and npm.

@gangstead gangstead deleted the fix-issue-36 branch January 25, 2016 18:26
@mcous
Copy link
Contributor Author

mcous commented Jan 25, 2016

v1.1.5 published to apm. And no worries; seems like keeping two separate package managers up to date on the same package is a pain. Speaking of pain:

  1. the npm version is out of sync with apm
    • npm already has v1.1.5 published
    • It matches Atom's v1.1.4
    • We should be able to fix by:
      1. $ apm publish patch - uprevs package.json to v1.1.6, tags release, pushes to apm
      2. $ npm publish - publishes v1.1.6 to npm as is
  2. I don't have publish permission for npm (apm goes off GitHub permissions, npm goes off their own)

Can you either take care of the uprev or add me as an owner to the npm package with $ npm owner add mcous? Fun times with package management...

@gangstead
Copy link
Contributor

Ownership added. Thanks for figuring this all out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants