-
Notifications
You must be signed in to change notification settings - Fork 25
Fix prefixed string handling #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prefixed string handling #33
Conversation
Cool 👍 |
Since it got transferred to atom-community I no longer have write access. |
Per @benogle in #28, @gangstead and @cjwilburn were given write access. At least one of those didn't seem to go through, so anyone at atom-community know what's going on? |
👍 |
Sorry for the delay. I think i've fixed the team permissions. @gangstead you should have write access now. |
Thanks. It looks like I have permissions now. |
👍 @cjwilburn Sorry about that. Oversight on my part |
Fix prefixed string handling
NPM says I don't have permission to do a patch publish. @benogle are there further github permissions that need to be changed? NPM still thinks I'm the owner of the package https://www.npmjs.com/package/language-scala |
|
@gangstead perhaps you meant to do |
Well this is embarrassing. |
There is also an npm module for some reason and I'm not able to publish to it. I don't know what that's about. |
Looks like that was from #9. I think npm publish and apm publish have slightly different semantics. Does |
|
It looks like npm is confused about user names:
|
Basically I can't RTFM. For npm it's two commands I was looking at https://www.npmjs.com/package/npm-publish not noticing that it was a package and not an alias used by TL;DR - After a brief refresher course both the Atom and NPM packages have the latest language-scala. |
So I made some changes to the grammar file to better support highlighting for s/f/raw/whatever prefixed strings (#10 and #32). I tried to line up the class names with the ones used for similar interpolations in other languages from official atom repos. I've been using this for a while and it works well for me.
Than being said, I'm not sure how compatible it is with different highlighting syntaxes (some cursory perusing of the different syntaxes seem to show a lot of differences). I use solarized-dark, but feedback on other schemes would be good and might necessitate changes.
Here's what it looks like on my machine:

