Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-1390 manual vs auto app creation #1239

Merged
merged 20 commits into from
Jun 7, 2022
Merged

Conversation

rachellerathbone
Copy link
Contributor

This PR includes UI for GHE: this new screen will allow users to select either automatic or manual app creation.

States of this new page:
Initial view

Screen Shot 2022-06-07 at 10 25 25 am

Hover state

There is a pointer cursor in the hover state (you can't see it as it disappears when taking a screenshot).

Screen Shot 2022-06-07 at 10 25 32 am

Version selected

Screen Shot 2022-06-07 at 10 25 39 am

Screen Shot 2022-06-07 at 10 25 45 am

What's not included in this PR:

  • navigation between screens. This PR focuses solely on the page and its various states. Navigation between screens will be addressed in issue 1406 after all new screens have been built.
  • GHE_SERVER feature flag: not needed until we introduce navigation for the GHE flow (this page is currently not rendered at any point)

@rachellerathbone rachellerathbone force-pushed the ARC-1390-manual-vs-auto branch from dca8390 to cebe49a Compare June 7, 2022 01:22
@rachellerathbone rachellerathbone marked this pull request as ready for review June 7, 2022 01:27
@rachellerathbone rachellerathbone requested a review from a team as a code owner June 7, 2022 01:27
@@ -0,0 +1,8 @@
$(".optionsCard").click(function (event) {
event.preventDefault();
const selectedVersion = $(event.target).data("type");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is really minor. I am happy with the code as it it. It is just suggestions:

It seems we don't need the .data("type") here. We can just do the following:

$(".optionsCard").click(function (event) {
	event.preventDefault();
	$(".optionsCard").removeClass("selected");
  $(event.target).closet('.optionsCard').addClass('selected');
	$(".optionBtn").prop("disabled", false).attr("aria-disabled", "false").addClass("aui-button-primary");
});

So @mboudreau opinions? You mentioned the "data('type')" yesterday, I want to ask your thoughts.


for this, we could replace the
$(event.target).closet('.optionsCard').addClass('selected');
to
$(event.currentTarget).addClass('selected');

gxueatlassian
gxueatlassian previously approved these changes Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants