-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC-1390 manual vs auto app creation #1239
Conversation
…thub-for-jira into ARC-1387-cloud-or-server-pg
dca8390
to
cebe49a
Compare
static/js/jira-select-card-option.js
Outdated
@@ -0,0 +1,8 @@ | |||
$(".optionsCard").click(function (event) { | |||
event.preventDefault(); | |||
const selectedVersion = $(event.target).data("type"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this is really minor. I am happy with the code as it it. It is just suggestions:
It seems we don't need the .data("type")
here. We can just do the following:
$(".optionsCard").click(function (event) {
event.preventDefault();
$(".optionsCard").removeClass("selected");
$(event.target).closet('.optionsCard').addClass('selected');
$(".optionBtn").prop("disabled", false).attr("aria-disabled", "false").addClass("aui-button-primary");
});
So @mboudreau opinions? You mentioned the "data('type')" yesterday, I want to ask your thoughts.
for this, we could replace the
$(event.target).closet('.optionsCard').addClass('selected');
to
$(event.currentTarget).addClass('selected');
This PR includes UI for GHE: this new screen will allow users to select either automatic or manual app creation.
States of this new page:
Initial view
Hover state
There is a pointer cursor in the hover state (you can't see it as it disappears when taking a screenshot).
Version selected
What's not included in this PR: