remove data type

atlassian · Jun 7, 2022 · 77efac5 · 77efac5
1 parent cebe49a
commit 77efac5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/static/js/jira-select-card-option.js b/static/js/jira-select-card-option.js
@@ -1,8 +1,6 @@
 $(".optionsCard").click(function (event) {
 	event.preventDefault();
-	const selectedVersion = $(event.target).data("type");
-
 	$(".optionsCard").removeClass("selected");
-	$(`.optionsCard.${selectedVersion}`).addClass("selected");
+	$(event.currentTarget).addClass("selected");
 	$(".optionBtn").prop("disabled", false).attr("aria-disabled", "false").addClass("aui-button-primary");
 });
diff --git a/views/partials/select-app-creation-card.hbs b/views/partials/select-app-creation-card.hbs
@@ -5,15 +5,13 @@
     {{#if isRecommended}}
         <span
             class="aui-lozenge aui-lozenge-subtle aui-lozenge-new jiraSelectAppCreation__options__recommended"
-            data-type="{{appCreationOption}}"
         >
             Recommended
         </span>
     {{/if}}
     <div class="jiraSelectAppCreation__options__card__iconContainer" data-type="{{appCreationOption}}">
         <img
             class="jiraSelectAppCreation__options__card__icon"
-            data-type="{{appCreationOption}}"
             src={{appCreationIcon}}
             alt={{appCreationIconAlt}}
         />
@@ -22,13 +20,11 @@
     <div class="jiraSelectAppCreation__options__card__contentContainer" data-type="{{appCreationOption}}">
       <h4
         class="jiraSelectAppCreation__options__card__title"
-        data-type="{{appCreationOption}}"
       >
         {{appCreationTitle}}
       </h4>
       <p
         class="jiraSelectAppCreation__options__card__info"
-        data-type="{{appCreationOption}}"
       >
         {{appCreationDescription}}
       </p>

diff --git a/views/partials/select-github-version-card.hbs b/views/partials/select-github-version-card.hbs
@@ -1,13 +1,11 @@
 <div
     class="jiraSelectGitHubVersion__options__card optionsCard {{gitHubVersion}}"
-    data-type="{{gitHubVersion}}"
 >
-  <h4 class="jiraSelectGitHubVersion__options__card__title" data-type="{{gitHubVersion}}">{{cardTitle}}</h4>
+  <h4 class="jiraSelectGitHubVersion__options__card__title">{{cardTitle}}</h4>
   <img
     class="jiraSelectGitHubVersion__options__card__img {{gitHubVersion}}"
     src={{cardImagePath}}
     alt={{cardImageAlt}}
-    data-type="{{gitHubVersion}}"
    />
-  <p class="jiraSelectGitHubVersion__options__card__info" data-type="{{gitHubVersion}}">{{cardContent}}</p>
+  <p class="jiraSelectGitHubVersion__options__card__info">{{cardContent}}</p>
 </div>