DCA1365: Bitbucket LTS - fix the issue with Selenium action "create_pull_request" #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opopovss
requested review from
OlehStefanyshyn,
SergeyMoroz0703,
astashys and
ometelytsia
as code owners
bot-dcapt
reviewed
Oct 27, 2021
Collaborator
bot-dcapt
left a comment
bot-dcapt
left a comment
There was a problem hiding this comment.
Linter flake8 results:
- app/selenium_ui/bitbucket/pages/pages.py:234:121: E501 line too long (122 > 120 characters)
ometelytsia
reviewed
Oct 27, 2021
| self.execute_js(f'document.querySelector("{PullRequestLocator.delete_branch_per_merge_checkbox[1]}").click()') | ||
| self.wait_until_clickable(PullRequestLocator.pull_request_modal_merge_button).click() | ||
| self.wait_until_invisible(PullRequestLocator.del_branch_checkbox_selector) | ||
| self.wait_until_visible(PullRequestLocator.merge_diagram_selector) |
Collaborator
There was a problem hiding this comment.
@opopovss did you test this on both old and new bitbucket versions?
Collaborator
There was a problem hiding this comment.
It would be nice to add the link to CI runs to the PR, so everyone can see what was tested on the branches.
Contributor
Author
There was a problem hiding this comment.
Done, added the link with the result of the run to the first comment
ometelytsia
approved these changes
Oct 27, 2021
SergeyMoroz0703
approved these changes
Oct 27, 2021
OlehStefanyshyn
approved these changes
Oct 27, 2021
opopovss
deleted the
DCA_1365_Bitbucket_LTS_fix_of_the_issue_with_Selenium_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI results after the run with changes Results