Skip to content

Commit 6b115f3

Browse files
authored
Merge pull request #704 from atlassian/DCA_1365_Bitbucket_LTS_fix_of_the_issue_with_Selenium_action
DCA1365: Bitbucket LTS - fix the issue with Selenium action "create_pull_request"
2 parents 8f85eb9 + 9ba2b96 commit 6b115f3

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

app/selenium_ui/bitbucket/pages/pages.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,12 @@ def merge_pull_request(self):
229229
self.wait_until_present(PullRequestLocator.pull_request_page_merge_button).click()
230230
PopupManager(self.driver).dismiss_default_popup()
231231
self.wait_until_visible(PullRequestLocator.diagram_selector)
232-
self.execute_js(f'document.querySelector("{PullRequestLocator.delete_branch_per_merge_checkbox[1]}").click()')
233-
self.wait_until_clickable(PullRequestLocator.pull_request_modal_merge_button).click()
234-
self.wait_until_invisible(PullRequestLocator.del_branch_checkbox_selector)
232+
self.wait_until_visible(PullRequestLocator.merge_diagram_selector)
233+
if self.get_element(PullRequestLocator.delete_branch_per_merge_checkbox).is_selected():
234+
self.execute_js(f'document.querySelector("{PullRequestLocator.delete_branch_per_merge_checkbox[1]}").click()')
235+
else:
236+
self.wait_until_clickable(PullRequestLocator.pull_request_modal_merge_button).click()
237+
self.wait_until_invisible(PullRequestLocator.del_branch_checkbox_selector)
235238

236239

237240
class RepositoryBranches(BasePage):

app/selenium_ui/bitbucket/pages/selectors.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ class PullRequestLocator:
186186

187187
merge_spinner = (By.CSS_SELECTOR, "aui-spinner[size='small']")
188188
diagram_selector = (By.CLASS_NAME, 'branches-diagram')
189+
merge_diagram_selector = (By.CLASS_NAME, "merge-diagram")
189190
pull_request_modal_merge_button = (By.CSS_SELECTOR, ".merge-dialog button[type='submit']")
190191
del_branch_checkbox_selector = (By.NAME, 'deleteSourceRef')
191192
delete_branch_per_merge_checkbox = (By.CSS_SELECTOR, "input[type='checkbox']")

0 commit comments

Comments
 (0)