Skip to content

Add functionality to delete a watcher from an issue #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

predominant
Copy link
Contributor

Signed-off-by: Graham Weldon graham@grahamweldon.com

adds issue_delete_watcher function.

Signed-off-by: Graham Weldon <graham@grahamweldon.com>
Signed-off-by: Graham Weldon <graham@grahamweldon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #884 (67427dc) into master (f9a5d4c) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   36.45%   36.44%   -0.02%     
==========================================
  Files          32       32              
  Lines        6246     6251       +5     
  Branches      902      902              
==========================================
+ Hits         2277     2278       +1     
- Misses       3861     3865       +4     
  Partials      108      108              
Impacted Files Coverage Δ
atlassian/jira.py 19.19% <20.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a5d4c...67427dc. Read the comment docs.

@gonchik gonchik merged commit 8914cb8 into atlassian-api:master Nov 11, 2021
@predominant predominant deleted the feature/delete-watcher branch November 11, 2021 22:50
@jensvog
Copy link
Contributor

jensvog commented Nov 21, 2021

Hi this wasn't working for me. Unlike in add watcher the user parameter has to be handed over as query parameter and not in the message body according to documentation: https://docs.atlassian.com/software/jira/docs/api/REST/8.13.14/#issue-removeWatcher. I created this PR #889 to fix.

jnhyperion added a commit to jnhyperion/atlassian-python-api that referenced this pull request Dec 3, 2021
…ython-api

* 'master' of https://github.com/atlassian-api/atlassian-python-api: (43 commits)
  Fix delete watchers (atlassian-api#889)
  Add function for getting watchers (atlassian-api#890)
  Add functionality to delete a watcher from an issue (atlassian-api#884)
  [Jira] Implement jira.update_version (atlassian-api#878)
  Bitbucket Cloud: Support for pull request tasks (atlassian-api#874)
  [Bitbucket] Fix pagination for cloud requests **FIX BLACK** (atlassian-api#872)
  [Bitbucket] get_users - addition for start and limit (atlassian-api#868)
  Develop (atlassian-api#870)
  Crowd: add additional functions (atlassian-api#865)
  Bump version
  Fix missing data when using pullRequests.each() (atlassian-api#861)
  Added parameters to projects get request (atlassian-api#859)
  Bump version with new parameter of token
  Jira: Add support for authentication through access token (atlassian-api#856)
  change: allow editor=v1 as a parameter of the create_page function (atlassian-api#857)
  Update rest_client.py (atlassian-api#854)
  Bump version of fork method
  Removing redundant double check for simpler code to read (atlassian-api#853)
  Fix up the docs to include the functions definitions for forking repositories (atlassian-api#852)
  [Bitbucket] Adding ability to fork a repo to a different project (atlassian-api#843)
  ...

# Conflicts:
#	atlassian/jira.py
gonchik pushed a commit that referenced this pull request Sep 3, 2022
* Add functionality to delete a watcher from an issue

Signed-off-by: Graham Weldon <graham@grahamweldon.com>

* Added docs

Signed-off-by: Graham Weldon <graham@grahamweldon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants