Skip to content

change: allow editor=v1 as a parameter of the create_page function #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eiju-akahane
Copy link
Contributor

The editor= parameter of the confluence.create_page API will accept 'v1' as well as 'v2' by this change.
The editor='v1' works both in confluence.create_page() and confluence.update_or_create() APIs.

Background:

  • The 'v1' parameter is required to make a copy of the existing Confluence page which expects old (v1) editor
    to maintain the appearance of the page.

@codecov-commenter
Copy link

Codecov Report

Merging #857 (7340b00) into master (694d799) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files          32       32           
  Lines        6169     6169           
  Branches      894      894           
=======================================
  Hits         2226     2226           
  Misses       3836     3836           
  Partials      107      107           
Impacted Files Coverage Δ
atlassian/confluence.py 12.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694d799...7340b00. Read the comment docs.

@gonchik gonchik merged commit 519813a into atlassian-api:master Sep 18, 2021
jnhyperion added a commit to jnhyperion/atlassian-python-api that referenced this pull request Dec 3, 2021
…ython-api

* 'master' of https://github.com/atlassian-api/atlassian-python-api: (43 commits)
  Fix delete watchers (atlassian-api#889)
  Add function for getting watchers (atlassian-api#890)
  Add functionality to delete a watcher from an issue (atlassian-api#884)
  [Jira] Implement jira.update_version (atlassian-api#878)
  Bitbucket Cloud: Support for pull request tasks (atlassian-api#874)
  [Bitbucket] Fix pagination for cloud requests **FIX BLACK** (atlassian-api#872)
  [Bitbucket] get_users - addition for start and limit (atlassian-api#868)
  Develop (atlassian-api#870)
  Crowd: add additional functions (atlassian-api#865)
  Bump version
  Fix missing data when using pullRequests.each() (atlassian-api#861)
  Added parameters to projects get request (atlassian-api#859)
  Bump version with new parameter of token
  Jira: Add support for authentication through access token (atlassian-api#856)
  change: allow editor=v1 as a parameter of the create_page function (atlassian-api#857)
  Update rest_client.py (atlassian-api#854)
  Bump version of fork method
  Removing redundant double check for simpler code to read (atlassian-api#853)
  Fix up the docs to include the functions definitions for forking repositories (atlassian-api#852)
  [Bitbucket] Adding ability to fork a repo to a different project (atlassian-api#843)
  ...

# Conflicts:
#	atlassian/jira.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants