Skip to content

[Enhancement] Add support for fetching id of blogpost #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2023
Merged

[Enhancement] Add support for fetching id of blogpost #1142

merged 2 commits into from
Apr 2, 2023

Conversation

praveen-kukreja
Copy link
Contributor

@praveen-kukreja praveen-kukreja commented Mar 22, 2023 •
edited
Loading

Closes #1141

Goal of this PR:

  • Update get_page_by_title to support blogpost too.
  • Update get_page_by_id to support blogpost.

Prereview Checklist

  • Tested the changes locally

@praveen-kukreja
Copy link
Contributor Author

praveen-kukreja commented Mar 22, 2023 •
edited
Loading

@gonchik I tried to keep the changes similar to the existing code, therefore used type as used in create_page method. However, Codacy is failing due to override of built-in type. Let me know if we are fine with this or if you have a better suggestion.

@gonchik gonchik merged commit dccd662 into atlassian-api:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] [Confluence] Implement a method to get the blogpost by title
2 participants
@praveen-kukreja @gonchik