Skip to content

Fire change event when user types in a new value or uses arrow keys #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xilocex
Copy link

@xilocex xilocex commented Jun 25, 2013

Added s.cH(s.$.val()); @line: 146 so that the change event is fired when a user types in a new value for the input.

This was pursued in response to Issue #89

Added s.cH(v); @line: 511 so that the change event is fired when a user has the input focused and is using the arrow keys.

xilocex added 2 commits June 25, 2013 02:13
Added s.cH(s.$.val()); @line: 146 so that the change event is fired when a user types in a new value for the input.
Added s.cH(v); @line: 511 so that the change event is fired when a user has the input focused and is using the arrow keys.
@j8
Copy link

j8 commented Oct 5, 2013

I added this @line: 166: s.cH(s.$.val()); to make the input value trigger the change event. Now it works great passing the input value to the callback.

@mickdekkers
Copy link

@xilocex @j8 These fixes worked, but if you type more than the maximum amount of digits in the input field then the change event still won't fire (and the dial won't draw, either). e.g. if you have set a max of 99 (2 digits) and you type 100 (3 digits), then it will clamp to 99 but when the input field loses focus the change event doesn't fire and the dial won't redraw.
The same goes for the minimum (e.g. typing -1 when the min is 0)
Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants