Always fire a change event when the user interacts with the knob #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- touch - wheel - typing (by binding to the "input" event) Previously, typing did not update the knob until focus was lost (and no change event was fired), and using the keyboard arrows did not fire any change events. Also move event triggering to val() and change() so it works always in the same way and less duplication exists.
|
Thank you! Now Knob works flawlessly 😀 |
aterrien
added a commit
that referenced
this pull request
Nov 19, 2013
Always fire a change event when the user interacts with the knob @amuino
aterrien
added a commit
that referenced
this pull request
Nov 19, 2013
aterrien
added a commit
that referenced
this pull request
Nov 19, 2013
|
This pull request introduces a bug when repainting on mouseup diplayPrevious enabled. You can see it on the demo page index.html. Can you fix it amuino ? |
amuino
pushed a commit
to amuino/jQuery-Knob
that referenced
this pull request
Nov 20, 2013
amuino
referenced
this pull request
in amuino/jQuery-Knob
Nov 20, 2013
That is, when using: - touch - wheel - typing (by binding to the "input" event) Previously, typing did not update the knob until focus was lost (and no change event was fired), and using the keyboard arrows did not fire any change events. Also move event triggering to val() and change() so it works always in the same way and less duplication exists. Similar to aterrien#130 but fixes an issue with `diplayPrevious`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, typing did not update the knob until focus was lost (and
no change event was fired), and
using the keyboard arrows did not fire any change events.
Also move event triggering to val() and change() so it works always
in the same way and less duplication exists.
Fixes #89 (a different approach than PR #102