docs: fixed broken link #4963
docs: fixed broken link #4963
Conversation
sengmonkham
requested review from
TRohit20,
asyncapi-bot-eve and
thulieblack
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA URL reference in the documentation's governance model section is corrected. The link to the governance charter document is updated from a root-level path to its current location within the docs directory structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4963 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@markdown/about/index.md`:
- Line 21: The CHARTER.md link in markdown/about/index.md was updated but other
files still reference the old root-level path; search for occurrences of
"CHARTER.md" and update each to "/docs/020-governance-and-policies/CHARTER.md"
(notably in markdown/blog/march-2021-at-asyncapi.md,
markdown/blog/new-governance-board.md,
markdown/blog/july-december-2021-at-asyncapi.md, and
markdown/blog/april-2021-at-asyncapi.md) and create a follow-up issue to sweep
the repo for any remaining outdated references and fix them consistently.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
markdown/about/index.md
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-latest
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| Free software allows users to apply, modify, and continue in the chain by distributing copies to help others and, in this case, disseminating modified versions of the specification. | ||
|
|
||
| Transferring AsyncAPI to the Linux Foundation and forming [an open governance model](https://github.com/asyncapi/community/blob/master/CHARTER.md) assures the community that a single company does not control AsyncAPI Initiative. This move takes the project to a higher level of transparency. | ||
| Transferring AsyncAPI to the Linux Foundation and forming [an open governance model](https://github.com/asyncapi/community/blob/master/docs/020-governance-and-policies/CHARTER.md) assures the community that a single company does not control AsyncAPI Initiative. This move takes the project to a higher level of transparency. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's check the actual content of the file at line 21
if [ -f "markdown/about/index.md" ]; then
echo "=== File exists, reading context around line 21 ==="
sed -n '18,24p' markdown/about/index.md
else
echo "File not found at markdown/about/index.md"
fiRepository: asyncapi/website
Length of output: 649
🏁 Script executed:
# Search for all references to CHARTER.md in the codebase
echo "=== Searching for CHARTER.md references ==="
rg "CHARTER\.md" --type md -B 2 -A 2Repository: asyncapi/website
Length of output: 7141
🏁 Script executed:
# Search for asyncapi/community references to understand the URL pattern
echo "=== Searching for asyncapi/community URLs ==="
rg "asyncapi/community/blob/master" --type md -B 1 -A 1Repository: asyncapi/website
Length of output: 24362
Fix is correct, but other outdated CHARTER.md references exist across the codebase.
The updated URL path to /docs/020-governance-and-policies/CHARTER.md is accurate. However, multiple files still reference the old root-level path and should be updated: markdown/blog/march-2021-at-asyncapi.md, markdown/blog/new-governance-board.md, markdown/blog/july-december-2021-at-asyncapi.md, and markdown/blog/april-2021-at-asyncapi.md. Consider creating a follow-up issue to systematically update all remaining outdated references.
🤖 Prompt for AI Agents
In `@markdown/about/index.md` at line 21, The CHARTER.md link in
markdown/about/index.md was updated but other files still reference the old
root-level path; search for occurrences of "CHARTER.md" and update each to
"/docs/020-governance-and-policies/CHARTER.md" (notably in
markdown/blog/march-2021-at-asyncapi.md, markdown/blog/new-governance-board.md,
markdown/blog/july-december-2021-at-asyncapi.md, and
markdown/blog/april-2021-at-asyncapi.md) and create a follow-up issue to sweep
the repo for any remaining outdated references and fix them consistently.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4963--asyncapi-website.netlify.app/ |
4 participants
Description
Fixed 404 error for the "open governance model" link on the About page.Updated the link to point to the correct location of the AsyncAPI Charter:
https://github.com/asyncapi/community/blob/master/docs/020-governance-and-policies/CHARTER.md.Related issue(s)
#4926
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.