chore: update tools.json #4800
chore: update tools.json #4800
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughTool catalog configurations were reorganized across two files. The Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4800 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 798 798
Branches 146 146
=========================================
Hits 798 798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4800--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
config/tools.json (1)
1375-1428: Remove personal test repository entries for AsyncAPI Studio from production tools.json.The Editors section contains three "AsyncAPI Studio" entries. The two new entries point to personal test repositories:
https://github.com/Shurtu-gal/action-test-bed(line 1380)https://github.com/TahaShahid203/async-api-issue(line 1407)Both have
"description": nulland are being auto-extracted from.asyncapi-toolfiles in those repositories through the build-tools script. These test repositories should not appear in the production tools catalog alongside the official AsyncAPI Studio (https://github.com/asyncapi/studio).Either remove the
.asyncapi-toolfiles from these test repositories, or exclude them from the automated extraction in the build-tools script.
♻️ Duplicate comments (1)
config/tools-automated.json (1)
368-406: Same suspicious AsyncAPI Studio entries as in tools.json.These two entries with personal test repository URLs (
Shurtu-gal/action-test-bedandTahaShahid203/async-api-issue) also appear here. TheisAsyncAPIOwner: falseflag correctly indicates these are not official AsyncAPI tools, but listing personal test repositories alongside the official Studio tool seems incorrect.
🧹 Nitpick comments (1)
config/tools-automated.json (1)
603-624: Inconsistent casing in Specmatic entry.The
languagevalue is"kotlin"(lowercase) and technology includes"maven"(lowercase), while other entries in this file use proper casing (e.g.,"Java","Maven","TypeScript").🔎 Suggested fix for consistent casing
"filters": { - "language": "kotlin", + "language": "Kotlin", "technology": [ "Docker", - "maven" + "Maven" ],
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/tools-automated.jsonconfig/tools.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: akshatnema
Repo: asyncapi/website PR: 3136
File: tests/fixtures/tools/automated-tools.json:8-9
Timestamp: 2024-11-01T12:48:22.034Z
Learning: In the `tests/fixtures/tools/automated-tools.json` file, the `language` field within the `filters` object can be either a string or an array. Both formats are acceptable and supported in the codebase.
📚 Learning: 2025-01-19T04:51:41.255Z
Learnt from: anshgoyalevil
Repo: asyncapi/website PR: 3557
File: tests/fixtures/markdown/check-edit-links-data.js:3-11
Timestamp: 2025-01-19T04:51:41.255Z
Learning: In the AsyncAPI website repository, the test data in `tests/fixtures/markdown/check-edit-links-data.js` intentionally includes inconsistent paths (with and without 'docs' prefix) to verify the script's ability to normalize and handle ambiguous path structures.
Applied to files:
config/tools.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: cypress-run
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (9)
config/tools-automated.json (9)
32-53: LGTM!The Zod Sockets entry is correctly structured with appropriate metadata for a code-first tool that also falls under DSL and framework categories.
54-97: LGTM!Both AsyncAPI.Net (LEGO) and AsyncAPI.NET (ByteBardOrg fork) entries are properly documented with distinct repository URLs and appropriate descriptions clarifying their relationship.
117-159: LGTM!The ChanX and SIO-AsyncAPI entries are correctly structured Python tools with appropriate language and technology metadata.
206-266: LGTM!ChanX appropriately appears in Code Generators section with its code-generator capability, and asyncapi-python entry is correctly structured for AMQP-based Python code generation.
432-483: LGTM!Zod Sockets and ZenWave SDK entries are correctly structured for the DSL category with appropriate cross-categorization.
627-692: LGTM!The Validators section entries are correctly structured with appropriate language, technology, and category metadata.
694-735: LGTM!The Compare tools section entries are correctly structured. AsyncAPI Diff is properly marked as
isAsyncAPIOwner: truewhile jasyncapicmp is marked as external.
737-849: LGTM!The CLIs section entries are correctly structured. The AsyncAPI CLI fork (
hkirat/asyncapi-fork) is appropriately marked withisAsyncAPIOwner: falseto distinguish it from the official CLI.Note: The Specmatic entry has the same casing inconsistency as flagged earlier.
978-1051: Multiple "HTML Template" entries with identical titles may create confusion.The Generator Templates section contains three entries with the title "HTML Template":
dipaksodani/async-gen(Line 980) - personal repo,isAsyncAPIOwner: falseasyncapi/html-template(Line 998) - official template,isAsyncAPIOwner: trueWSOL12/html-template(Line 1036) - personal repo,isAsyncAPIOwner: falseWhile
isAsyncAPIOwnercorrectly marks ownership, having multiple identically-titled entries from different sources may confuse users searching for the official template. Thenulldescriptions are expected when GitHub repositories lack descriptions, so this alone isn't an issue.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Bug Fixes
Updates
✏️ Tip: You can customize this high-level summary in your review settings.