-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update tools.json #4332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tools.json #4332
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughSweeping metadata updates in tooling catalogs. config/tools-automated.json reclassifies and renames multiple tools and generator templates, adds CLIs, and swaps entries across sections. Both config files swap the two “GitHub Action for Generator” entries, adjusting description, repoUrl, categories, and ownership flags. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4332 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4332--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
config/tools-automated.json (1)
696-807: Standardize language filter values to canonical formsThe automated config still contains non-canonical language literals that will break filtering and theming. No category mismatches were found—only the language values need correction.
Please update
config/tools-automated.json(around lines 696–807) so that every"filters.language"matches the canonical set fromconfig/tools.json:• Replace
"Go"or"golang"→"Go/Golang"
• Replace"Typescript"→"TypeScript"
• Replace"javascript"→"JavaScript"
• Replace"python"→"Python"
• Replace"kotlin"→"Kotlin"After these edits, rerun the facet‐generation to confirm all filters align with the existing categories and languages.
🧹 Nitpick comments (13)
config/tools-automated.json (13)
53-69: Correct casing for language and standardize technology naming.
- "Typescript" should be "TypeScript" to match canonical naming used elsewhere in this file.
- "NestJS" is fine, but ensure we consistently use "NestJS" (not "Nest Js") across this file.
- "language": "Typescript", + "language": "TypeScript",
514-533: Normalize casing and category for Specmatic.
- "kotlin" -> "Kotlin"
- "maven" -> "Maven"
- Category "CLIs" -> "cli" to be consistent with other entries.
- "language": "kotlin", + "language": "Kotlin", "technology": [ - "Docker", - "maven" + "Docker", + "Maven" ], "categories": [ "mocking-and-testing", - "CLIs" + "cli" ], - "hasCommercial": true, + "hasCommercial": true,
699-719: Same normalization needed for Specmatic CLI entry.Replicate the Specmatic casing/category fixes here.
- "title": "Specmatic", + "title": "Specmatic", "description": "Transform your API Specs into Executable Contracts with #NoCode in Seconds. Experience the power of Contract-Driven Development to confidently develop and independently deploy your Microservices and Microfrontends faster", "links": { "websiteUrl": "https://specmatic.io", "docsUrl": "https://specmatic.io/documentation/", "repoUrl": "https://github.com/specmatic/specmatic" }, "filters": { - "language": "kotlin", + "language": "Kotlin", "technology": [ "Docker", - "maven" + "Maven" ], "categories": [ "mocking-and-testing", - "CLIs" + "cli" ], "hasCommercial": true, "isAsyncAPIOwner": false }
165-177: Normalize language value for Golang generator.Use consistent casing across the catalog. Recommend "Go/Golang" (used in tools.json) or "Go". Pick one and stick to it.
- "language": "golang", + "language": "Go/Golang",
201-218: Normalize language casing for asyncapi-python."python" -> "Python" for consistency.
- "language": "python", + "language": "Python",
371-388: Fix technology casing: "React js" -> "React JS".Consistent casing improves filtering and theming.
"technology": [ - "React js", + "React JS", "WebComponents" ],
899-915: Fix language casing for Node.js WebSockets template."javascript" -> "JavaScript".
- "language": "javascript", + "language": "JavaScript",
917-935: Unify language field shape and casing for Java Template.
- Avoid mixing array vs. string for "language" across this file.
- Use "JavaScript" (cased) like other template entries.
- "language": [ - "javascript" - ], + "language": "JavaScript",Note: Consider whether "technology": ["Java"] is intended to indicate the target platform. If not, align with other entries (e.g., template implementation tech like Node.js). Please confirm the intended schema.
937-955: Unify language field shape for Java Spring Cloud Stream Template.- "language": [ - "javascript" - ], + "language": "JavaScript",
958-977: Unify language field shape and casing for Java Spring Template.- "language": [ - "javascript" - ], + "language": "JavaScript",
980-995: Fix language casing for HTML Template.- "language": "javascript", + "language": "JavaScript",
998-1013: Fix language casing for Node.js Multiprotocol Template.- "language": "javascript", + "language": "JavaScript",
1016-1031: Fix language casing for alternate HTML Template entry.- "language": "javascript", + "language": "JavaScript",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
config/tools-automated.json(11 hunks)config/tools.json(3 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (6)
config/tools.json (2)
1727-1745: Sanity check: swapped metadata looks internally consistent.The first "GitHub Action for Generator" block now points to the actions-marketplace-validations repo and uses "github-action" category. No functional issues spotted here.
Please verify marketplace link (websiteUrl) is intentionally omitted for this entry, as other actions often include it. If desired, add:
- "websiteUrl": "https://github.com/marketplace/actions/asyncapi-generator"
1748-1766: Fix plural category key and confirm entry classification
- Change the category for this entry in both files from
"github-actions"to"github-action":
- config/tools.json (lines 1748–1766)
- config/tools-automated.json (around line 126)
- Note that other entries use the plural
"CLIs"—you may want to update those to the singular"cli"for consistency across both configs.- Verify whether this item is actually the AsyncAPI CLI (it should then be retitled “AsyncAPI CLI” and grouped under the
clicategory) or the GitHub Action for the generator (in which case adjust itsrepoUrl,title, and keep it undergithub-action).--- a/config/tools.json +++ b/config/tools.json @@ -1748,3 +1748,3 @@ - "categories": [ - "github-actions" - ], + "categories": [ + "github-action" + ],--- a/config/tools-automated.json +++ b/config/tools-automated.json @@ -124,3 +124,3 @@ - "categories": [ - "github-actions" - ], + "categories": [ + "github-action" + ],config/tools-automated.json (4)
72-91: LGTM on AsyncAPI.Net entry swap.Links, language, technologies, and categories are consistent and correctly cased.
536-556: LGTM: Mokapi metadata looks correct after swap.Casing, tech, categories, and URLs are consistent.
764-787: LGTM: ZenWave SDK CLI entry content looks consistent.Tech list and categories align with other sections; ownership and commercial fields are coherent.
475-489: Use singular category "github-action" and keep ownership as-is.Plural "github-actions" appears elsewhere; the convention here is singular. Keep "isAsyncAPIOwner": false.
"categories": [ - "github-action" + "github-action" ], "hasCommercial": false, - "isAsyncAPIOwner": false + "isAsyncAPIOwner": falseNote: No functional changes besides reaffirming the category; included to emphasize singular form is expected.
Likely an incorrect or invalid review comment.
| "title": "GitHub Action for Generator", | ||
| "description": null, | ||
| "description": "CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!", | ||
| "links": { | ||
| "repoUrl": "https://github.com/actions-marketplace-validations/asyncapi_github-action-for-generator" | ||
| "repoUrl": "https://github.com/asyncapi/cli" | ||
| }, | ||
| "filters": { | ||
| "technology": [ | ||
| "AsyncAPI Generator" | ||
| ], | ||
| "categories": [ | ||
| "github-action" | ||
| "github-actions" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| "isAsyncAPIOwner": true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Fix category pluralization and double-check this entry isn’t the CLI.
- Category should be "github-action" (singular).
- This entry points to asyncapi/cli, which likely doesn’t belong under GitHub Actions with this title.
"categories": [
- "github-actions"
+ "github-action"
],Follow-up: Confirm if this block should represent the GitHub Action (and not the CLI). If it’s the CLI, consider moving it under CLIs and retitling to "AsyncAPI CLI".
Correct resource type and category
- Change the
filters.categoriesvalue on lines 492–506:"categories": [ - "github-actions" + "github-action" ],
- This entry’s
repoUrl(asyncapi/cli) and description clearly describe the CLI, not a GitHub Action. To resolve:
• If you intend to list the AsyncAPI CLI here:
– Retitle to"title": "AsyncAPI CLI"
– Setfilters.technologyto"CLI"
– Changefilters.categoriesto["cli"]
– Move this block under your CLIs section
• Otherwise, if you meant to reference the GitHub Action for Generator:
– Updatelinks.repoUrlto the actual action repo (e.g.https://github.com/asyncapi/generator-action)
– Adjusttitleanddescriptionto describe the action
– Ensurefilters.technologyremains"AsyncAPI Generator"andfilters.categoriesis["github-action"]
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "GitHub Action for Generator", | |
| "description": null, | |
| "description": "CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!", | |
| "links": { | |
| "repoUrl": "https://github.com/actions-marketplace-validations/asyncapi_github-action-for-generator" | |
| "repoUrl": "https://github.com/asyncapi/cli" | |
| }, | |
| "filters": { | |
| "technology": [ | |
| "AsyncAPI Generator" | |
| ], | |
| "categories": [ | |
| "github-action" | |
| "github-actions" | |
| ], | |
| "hasCommercial": false, | |
| "isAsyncAPIOwner": false | |
| "isAsyncAPIOwner": true | |
| } | |
| "title": "GitHub Action for Generator", | |
| "description": "CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/cli" | |
| }, | |
| "filters": { | |
| "technology": [ | |
| "AsyncAPI Generator" | |
| ], | |
| "categories": [ | |
| "github-action" | |
| ], | |
| "hasCommercial": false, | |
| "isAsyncAPIOwner": true | |
| } |
🤖 Prompt for AI Agents
config/tools-automated.json around lines 492 to 506: the entry currently labeled
"GitHub Action for Generator" points to the AsyncAPI CLI repo and is
mis-categorized; either convert this block to correctly represent the AsyncAPI
CLI (change "title" to "AsyncAPI CLI", set "filters.technology" to "CLI", set
"filters.categories" to ["cli"], and move the block to the CLIs section) or
instead make it a true GitHub Action entry (update "links.repoUrl" to the actual
action repo such as https://github.com/asyncapi/generator-action, update "title"
and "description" to describe the action, keep "filters.technology" as "AsyncAPI
Generator" and set "filters.categories" to ["github-action"]).
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Refactor
Chores