-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(community): update latest tsc members list #4478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update latest tsc members list #4478
Conversation
❌ Deploy Preview for asyncapi-website failed.
|
WalkthroughAdds a new ambassador entry for Ankit Kumar to config/AMBASSADORS_MEMBERS.json, including profile fields (name, GitHub, IDs, social links, company, title, bio, image) and a contributions array with talks, booth activity, and articles. No other files or existing entries were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4478 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/AMBASSADORS_MEMBERS.json (2)
755-766: New ambassador entry looks good; confirm TSC status and field norms
- Please confirm if Ankit Kumar should be marked as a TSC member per PR title. If yes, add "isTscMember": true.
- Optional: align linkedin format (slug vs full URL) with project conventions.
786-793: Normalize contribution type "booth" to avoid schema/UX mismatchPast entries use "special contribution" for booth duty. If the site expects a fixed enum, "booth" may break filters/rendering. Recommend aligning:
- { - "type": "booth", + { + "type": "special contribution", "title": "Manned the AsyncAPI booth during APIDays Singapore to connect with developers and promote the AsyncAPI initiative.", "date": { "year": 2025, "month": "April" }, "link": "" },
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/AMBASSADORS_MEMBERS.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
Updated Ambassadors list is available and this PR introduces changes with latest information about Ambassadors list
Summary by CodeRabbit