-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(community): update latest tsc members list #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update latest tsc members list #4106
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughA new ambassador, Naresh Jain, was added to the Changes
Sequence Diagram(s)sequenceDiagram
participant Contributor
participant JSON File
participant Website
Contributor->>JSON File: Add new ambassador entry (Naresh Jain)
JSON File-->>Website: Updated ambassador data available
Website->>User: Display new ambassador profile and contributions
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/AMBASSADORS_MEMBERS.json (1)
672-722: New ambassador entry for Naresh Jain looks complete but check social media URL consistency.The object includes all required fields and valid contributions. However, most entries specify
"lornajane") rather than a full URL. Please confirm whether full URLs are supported by your rendering code or switch to slug-only format for consistency. Additionally, if Naresh is a current TSC member, consider adding anisTscMemberflag here as well.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/AMBASSADORS_MEMBERS.json(6 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (4)
config/AMBASSADORS_MEMBERS.json (4)
65-65: Ensure thatisTscMemberproperty is supported by the schema and tooling.The new
isTscMemberflag on Daniel Kocot’s entry clearly indicates his TSC membership, but please verify that the site’s JSON schema or rendering logic recognizes this field. If it isn’t declared in your types or validation rules, it may be ignored or trigger errors during build/deploy.
76-102: New contributions for Daniel Kocot look good.The added articles (“AsyncAPI specification updates”) and presentations (“AsyncAPI 101”, “Adopting AsyncAPI in Enterprisey Contexts…”) follow the existing JSON structure, include valid dates and links, and are properly indented. No issues spotted.
224-224: Title update for Ivan Garcia Sainz-Aja is consistent.Your new
titlevalue accurately reflects his current roles and the JSON syntax is valid.
623-632: Formatting cleanup for Laurent Broudoux contributions.Trailing whitespace has been removed and the empty
linkfields are left blank intentionally. JSON formatting remains correct and valid.
Updated Ambassadors list is available and this PR introduces changes with latest information about Ambassadors list
Summary by CodeRabbit
New Features
Style