ci: update of files from global .github repo #4418
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughWorkflows refactor step scripts to use environment variables instead of GitHub context expressions for actor, event metadata, and release data. Minor quoting/argument handling updates are added in transfer-issue. No structural changes to job/step ordering; logic remains functionally equivalent. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Maintainer
participant GH as GitHub Actions
participant Slack as Slack API
participant Twitter as Twitter API
Note over GH: Release Announcements Workflow
Maintainer->>GH: Publish GitHub Release
GH->>GH: Set env (RELEASE_TAG, URL, BODY, REPO_NAME, AUTHOR_NAME)
GH->>Slack: Post release markdown (uses env vars)
alt Release tweet enabled
GH->>GH: Determine semver diff (PREV_VERSION/LAST_VERSION via env)
GH->>Twitter: Publish tweet (uses env vars)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4418--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
.github/workflows/bounty-program-commands.yml (4)
26-29: Fix incorrect actor allowlist check (|| with strings collapses to first value).
('aeworxet' || 'thulieblack')evaluates to'aeworxet', sothulieblackis never considered. Use explicit comparisons or array membership.Apply:
- if: > - github.actor != ('aeworxet' || 'thulieblack') && + if: > + github.actor != 'aeworxet' && + github.actor != 'thulieblack' && ( startsWith(github.event.comment.body, '/bounty' ) )
54-57: Same allowlist bug in the “add-label-bounty” job.Only
aeworxetpasses today;thulieblackis excluded.- if: > - github.actor == ('aeworxet' || 'thulieblack') && + if: > + (github.actor == 'aeworxet' || github.actor == 'thulieblack') && ( startsWith(github.event.comment.body, '/bounty' ) )
95-98: Same allowlist bug in the “remove-label-bounty” job.Mirror the fix to ensure both users are allowed.
- if: > - github.actor == ('aeworxet' || 'thulieblack') && + if: > + (github.actor == 'aeworxet' || github.actor == 'thulieblack') && ( startsWith(github.event.comment.body, '/unbounty' ) )
119-124:issues.removeLabelexpects a string forname, not an array.Passing
[BOUNTY_PROGRAM_LABELS[0].name]will fail at runtime.- github.rest.issues.removeLabel({ + await github.rest.issues.removeLabel({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - name: [BOUNTY_PROGRAM_LABELS[0].name] + name: BOUNTY_PROGRAM_LABELS[0].name })
🧹 Nitpick comments (13)
.github/workflows/bounty-program-commands.yml (2)
36-37: Good switch to env for actor; also await API calls for reliability.Env-based actor usage looks good. Add
awaittocreateCommentto avoid the step finishing before the API call resolves.- github.rest.issues.createComment({ + await github.rest.issues.createComment({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, body: commentText })Also applies to: 41-50
85-91: Await label addition for consistency.Ensure the label API call settles before the step ends.
- github.rest.issues.addLabels({ + await github.rest.issues.addLabels({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, labels: [BOUNTY_PROGRAM_LABELS[0].name] }).github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml (1)
40-46: Await GitHub API calls to avoid races.Add
awaittoaddLabelsandcreateComment.- github.rest.issues.addLabels({ + await github.rest.issues.addLabels({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, labels: ['ready-to-merge'] })- github.rest.issues.createComment({ + await github.rest.issues.createComment({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, body: `Hello, @${process.env.GITHUB_ACTOR}! 👋🏼Also applies to: 57-69
.github/workflows/help-command.yml (3)
18-20: Env-based actor usage: LGTM; await the API call.Switch to env is correct. Also add
awaittocreateComment.- github.rest.issues.createComment({ + await github.rest.issues.createComment({Also applies to: 30-41
36-36: Typo in user-facing text (“reviewrs”).Fix spelling.
- - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet. + - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewers who have not reviewed the PR yet.
49-51: Mirror the await fix in the issue flow.Add
awaitbeforecreateComment.- github.rest.issues.createComment({ + await github.rest.issues.createComment({Also applies to: 54-67
.github/workflows/transfer-issue.yml (2)
26-27: Extraction is better with quoting; add validation and strict shell opts.Guard against empty/invalid repo and fail fast.
- REPO=$(echo "$COMMENT" | awk '{print $2}') - echo "repo=$REPO" >> $GITHUB_OUTPUT + set -euo pipefail + REPO="$(echo "$COMMENT" | awk '{print $2}')" + if [[ -z "${REPO:-}" || ! "$REPO" =~ ^[A-Za-z0-9._-]+$ ]]; then + echo "Invalid or missing repo name in command. Usage: /ti <repo-name>" + exit 1 + fi + echo "repo=$REPO" >> "$GITHUB_OUTPUT"
60-63: Token naming consistency (optional).You use
secrets.GH_TOKENin “Check Repo” butsecrets.GITHUB_TOKENhere. Prefer one consistently (either works for gh CLI if scoped properly).Would you like me to align both steps to the same secret name across repos?
.github/workflows/issues-prs-notifications.yml (4)
26-32: Env-based composition: LGTM. Consider null-safe fallbacks.Issue body can be null; default to empty to avoid “null” in Slack.
- ISSUE_BODY: ${{github.event.issue.body}} + ISSUE_BODY: ${{ github.event.issue.body || '' }}
48-54: Apply the same null-safe fallback for PR body.- PR_BODY: ${{github.event.pull_request.body}} + PR_BODY: ${{ github.event.pull_request.body || '' }}
70-76: Apply the same null-safe fallback for Discussion body.- DISCUSSION_BODY: ${{github.event.discussion.body}} + DISCUSSION_BODY: ${{ github.event.discussion.body || '' }}
64-64: Minor copy: job/step names say “pull request” in the discussion job.Rename for clarity in Actions UI.
- name: Notify slack on every new pull request + name: Notify slack on every new discussion- - name: Convert markdown to slack markdown for pull request + - name: Convert markdown to slack markdown for discussionAlso applies to: 67-67
.github/workflows/release-announcements.yml (1)
71-75: Twitter flow updates look good; tiny robustness nit.Using envs for
semver-diffand tweet text is solid. If you want to be extra safe, quotenpxargs (already done) and keep as-is.Also applies to: 85-92
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml(2 hunks).github/workflows/bounty-program-commands.yml(1 hunks).github/workflows/help-command.yml(3 hunks).github/workflows/issues-prs-notifications.yml(3 hunks).github/workflows/release-announcements.yml(2 hunks).github/workflows/transfer-issue.yml(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-02-18T12:07:42.211Z
Learnt from: asyncapi-bot
PR: asyncapi/website#0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
Applied to files:
.github/workflows/issues-prs-notifications.yml
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml (1)
30-31: Env-based actor usage: LGTM.Using
process.env.GITHUB_ACTORis correct and consistent with the repo-wide change.Also applies to: 61-68
.github/workflows/transfer-issue.yml (1)
58-63: Good: arguments are now quoted and sourced from env.Quoting both ISSUE_NUMBER and REPO_NAME eliminates whitespace parsing bugs.
.github/workflows/release-announcements.yml (1)
22-28: Env-based metadata propagation: LGTM.Switching to env for Slack message composition and title is clean and consistent.
Also applies to: 31-37
|
/rtm |
* docs(community): update latest community documentation (#4407) * chore: update meetings.json and newsrooom_videos.json (#4410) * chore: update meetings.json and newsrooom_videos.json (#4405) * chore: update meetings.json, newsrooom_videos.json and dashboard.json * Update meetings.json --------- Co-authored-by: asyncapi-bot <info@asyncapi.io> Co-authored-by: Eve <bot+eve@asyncapi.io> Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> * chore: update meetings.json and newsrooom_videos.json (#4411) * fix: #4065 Made Case Studies page table section mobile responsive (#4403) * fixes #4065. Made Case Studie page mobile responsive * fixes #4065. Made Case Studie page mobile responsive * fix: #4381 --------- Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> * chore(deps): bump axios from 1.8.2 to 1.12.1 (#4413) * chore(deps): bump @babel/runtime and next-language-detector (#4414) * chore: update tools.json (#4417) * chore: update meetings.json and newsrooom_videos.json (#4419) * ci: update of files from global .github repo (#4418) * fix: broken AsyncAPI contributing guidelines link (#4395) (#4398) Co-authored-by: SanidhyaMadheshia <sanidhyamadheshia@gmail.com> Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com> --------- Co-authored-by: Chan <bot+chan@asyncapi.io> Co-authored-by: asyncapi-bot <info@asyncapi.io> Co-authored-by: Eve <bot+eve@asyncapi.io> Co-authored-by: namanjain24-sudo <namanjainpy@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SanidhyaMadheshia <139427620+SanidhyaMadheshia@users.noreply.github.com> Co-authored-by: SanidhyaMadheshia <sanidhyamadheshia@gmail.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com>
Summary by CodeRabbit
Bug Fixes
Chores