-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: broken AsyncAPI contributing guidelines link (#4395) #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken AsyncAPI contributing guidelines link (#4395) #4398
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughUpdated a documentation file by replacing a relative CONTRIBUTING link with an absolute GitHub URL and formatting the line as a blockquote. No code, API, or public entity changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4398--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
markdown/docs/community/000-onboarding/index.md (1)
9-9: Prefer resilient link target and avoid blockquote stylingGood fix. Two small improvements:
- Use GitHub’s branch-agnostic
HEADso the link survives branch renames.- Link to org-wide contributing guide (matches the “various ways you can contribute to the AsyncAPI Initiative” wording). Alternatively, keep the repo-specific guide but still switch to
HEAD.Apply:
- > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/website/blob/master/CONTRIBUTING.md). +For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/.github/blob/HEAD/CONTRIBUTING.md).
- If you want to keep it repo-specific, use: https://github.com/asyncapi/website/blob/HEAD/CONTRIBUTING.md
References: org-wide CONTRIBUTING exists, and the website repo also has its own CONTRIBUTING. (github.com)
| The AsyncAPI technical writer onboarding guide teaches new community members how to contribute to our documentation effectively. | ||
|
|
||
| > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](../../CONTRIBUTING.md). | ||
| > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/website/blob/master/CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thulieblack Since we're not publishing CONTRIBUTING.md, I'm wondering, which one should we use - from the website or community repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thulieblack I highly recommend and would also love to work in making CONTRIBUTING.md publish in website only.
As it will give a better UX and UI which is eventually required for better communication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each repo has a different CONTRIBUTING.md file. The one that has the community repo is general, so it's best to use that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bandantonio can you please suggest me the changes I should do or the core area to consider that I am lacking. |
|
@SanidhyaMadheshia what changes are you talking about? |
I was asking if i should build a page dedicated to this CONTRIBUTING.md file in codebase . so that user can have a better ux. |
|
You shouldn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
markdown/docs/community/000-onboarding/index.md (1)
9-9: Link should target the community repo CONTRIBUTING.md (per maintainer guidance).Past review concluded to link the general CONTRIBUTING in asyncapi/community, not website. Update the URL accordingly. The file exists here. (github.com)
Apply this diff:
- > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/website/blob/master/CONTRIBUTING.md). + > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/community/blob/HEAD/CONTRIBUTING.md).
🧹 Nitpick comments (1)
markdown/docs/community/000-onboarding/index.md (1)
9-9: Nit: Avoid blockquote styling unless intentional.Keeps the page’s typographic rhythm consistent with surrounding paragraphs.
Optional diff:
- > For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/community/blob/HEAD/CONTRIBUTING.md). + For a comprehensive understanding of the various ways you can contribute to the AsyncAPI Initiative, please consult the [AsyncAPI contributing guidelines](https://github.com/asyncapi/community/blob/HEAD/CONTRIBUTING.md).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
markdown/docs/community/000-onboarding/index.md(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
@sambhavgupta0705 done the update |
|
@thulieblack is any other changes i have to do..? |
thulieblack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
|
/rtm |
* docs(community): update latest community documentation (#4407) * chore: update meetings.json and newsrooom_videos.json (#4410) * chore: update meetings.json and newsrooom_videos.json (#4405) * chore: update meetings.json, newsrooom_videos.json and dashboard.json * Update meetings.json --------- Co-authored-by: asyncapi-bot <info@asyncapi.io> Co-authored-by: Eve <bot+eve@asyncapi.io> Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> * chore: update meetings.json and newsrooom_videos.json (#4411) * fix: #4065 Made Case Studies page table section mobile responsive (#4403) * fixes #4065. Made Case Studie page mobile responsive * fixes #4065. Made Case Studie page mobile responsive * fix: #4381 --------- Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> * chore(deps): bump axios from 1.8.2 to 1.12.1 (#4413) * chore(deps): bump @babel/runtime and next-language-detector (#4414) * chore: update tools.json (#4417) * chore: update meetings.json and newsrooom_videos.json (#4419) * ci: update of files from global .github repo (#4418) * fix: broken AsyncAPI contributing guidelines link (#4395) (#4398) Co-authored-by: SanidhyaMadheshia <sanidhyamadheshia@gmail.com> Co-authored-by: Sambhav Gupta <81870866+sambhavgupta0705@users.noreply.github.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com> --------- Co-authored-by: Chan <bot+chan@asyncapi.io> Co-authored-by: asyncapi-bot <info@asyncapi.io> Co-authored-by: Eve <bot+eve@asyncapi.io> Co-authored-by: namanjain24-sudo <namanjainpy@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SanidhyaMadheshia <139427620+SanidhyaMadheshia@users.noreply.github.com> Co-authored-by: SanidhyaMadheshia <sanidhyamadheshia@gmail.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com>
Description
fixed the broken contributing guidelines link on /docs/community/000-onboarding page
Related issue(s)
issue: #4395
now on clicking on contributing guidelines link

it goes to
Summary by CodeRabbit