Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix misaligned cards in ambassador list items on Ambassadors page #3945

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tutankhAman
Copy link

@tutankhAman tutankhAman commented Mar 22, 2025

Description
Changed link.title attribute to justify-center instead of justify-start.

Related issue(s)
Resolves #3937

Summary by CodeRabbit

  • Style
    • Adjusted the alignment of list items on the community ambassadors page from centered to start-aligned, enhancing the visual presentation.

Copy link
Contributor

coderabbitai bot commented Mar 22, 2025

Walkthrough

This change updates a list item's alignment on the community ambassadors page by modifying its CSS class. The <li> element in the pages/community/ambassadors/index.tsx file was altered from justify-center to justify-start, which adjusts the horizontal alignment of the content. No additional logic or functionality was impacted in this update.

Changes

File(s) Change Summary
pages/.../ambassadors/index.tsx Updated <li> class from justify-center to justify-start to fix alignment of ambassador cards.

Assessment against linked issues

Objective Addressed Explanation
Fix misaligned ambassador cards (#3937)

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • devilkiller-ag
  • sambhavgupta0705
  • asyncapi-bot-eve
  • Mayaleeeee
  • anshgoyalevil

Poem

Hop along, I tweak the code with cheer,
From centered bounds to a start so clear.
A little shift to make things right,
Cards now line up in perfect sight.
I’m a bunny with a knack for style,
Hopping through code mile by mile!
🐰✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 398dfc8 and a82d62e.

📒 Files selected for processing (1)
  • pages/community/ambassadors/index.tsx (1 hunks)
🔇 Additional comments (1)
pages/community/ambassadors/index.tsx (1)

95-95: Visual alignment fix correctly implemented

The change from justify-center to justify-start properly addresses the misalignment issue with the ambassador list items. In a flex column layout, this adjustment ensures content aligns to the top of each card rather than being vertically centered, which matches the intended design.

Note: There appears to be a discrepancy between the PR description (which mentions changing from justify-start to justify-center) and the actual code change (which shows the opposite). The implemented change seems correct based on typical card layout patterns.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65406b3
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67e3272599c64200086c269d
😎 Deploy Preview https://deploy-preview-3945--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (148ad21) to head (65406b3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3945   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          667       667           
  Branches       113       113           
=========================================
  Hits           667       667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tutankhAman tutankhAman changed the title Fixed misaligned cards in ambassador list items on Ambassadors page #3937 fix: Fixed misaligned cards in ambassador list items on Ambassadors page #3937 Mar 22, 2025
@tutankhAman tutankhAman changed the title fix: Fixed misaligned cards in ambassador list items on Ambassadors page #3937 fix: fix misaligned cards in ambassador list items on Ambassadors page Mar 22, 2025
@tutankhAman
Copy link
Author

@anshgoyalevil @akshatnema @sambhavgupta0705,
Can you please review my PR? I'd love to know if any other changes are required!
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned cards in ambassadorList
2 participants