fix: misaligned ambassador bio text in cards #3848

priyanshuxkumar · 2025-03-08T19:15:39Z

Fixed unwanted space in ambassador bio cards
Fixes #3839

Summary by CodeRabbit

Style
- Improved the ambassador display layout for enhanced vertical alignment and spacing.
- Adjusted the positioning of social media links to consistently appear at the bottom of the content area.

coderabbitai · 2025-03-08T19:15:45Z

Walkthrough

This pull request updates the layout of the ambassador section on the community page. In the pages/community/ambassadors/index.tsx file, the outer container has been updated with flexbox classes (flex h-full flex-col justify-between). These modifications adjust the vertical alignment and spacing of the ambassador's bio and social links. No changes were made to any exported or public declarations.

Changes

File	Change Summary
`pages/.../ambassadors/index.tsx`	Updated the ambassador display section: added `flex h-full flex-col justify-between` to the outer `<div>`.

Suggested labels

ready-to-merge

Suggested reviewers

derberg
magicmatatjahu
akshatnema
sambhavgupta0705
anshgoyalevil
Mayaleeeee
asyncapi-bot-eve

Poem

I'm a rabbit in the code-filled wood,
Flexing through the pages as best I could.
With a switch to flex and a twist of justify,
The layout's now neat, and the content feels spry.
Hopping over changes with a joyful "Yippee!"
🐇🌟

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2af74b6 and 91a2d7d.

📒 Files selected for processing (1)

pages/community/ambassadors/index.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

pages/community/ambassadors/index.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-08T19:16:50Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`00bea67`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67cc975d604237000878b6dc
😎 Deploy Preview	https://deploy-preview-3848--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2025-03-08T19:17:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (11c662a) to head (66f8fd5).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #3848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          667       667           
  Branches       113       113           
=========================================
  Hits           667       667

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

netlify · 2025-03-08T19:20:16Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`66f8fd5`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67cd65c70c472a00080e92e7
😎 Deploy Preview	https://deploy-preview-3848--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

akshatnema · 2025-03-08T20:41:38Z

pages/community/ambassadors/index.tsx

                <div className='p-2 text-sm'>{ambassador.bio}</div>
-                <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'>
+                <div className='mt-auto flex border-t p-2' data-testid='Ambassadors-members-socials'>


Instead of providing mt-auto as the classname, shouldn't we use justify-content to be space-between here?

Yes , I've made the changes and updated the PR. Please review it and let me know if any further modifications are required.

anshgoyalevil · 2025-03-09T10:00:25Z

/rtm

fix: misalignment in ambassador bio

00bea67

priyanshuxkumar requested review from derberg, akshatnema, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners March 8, 2025 19:15

asyncapi-bot requested review from devilkiller-ag and sambhavgupta0705 March 8, 2025 19:15

Merge branch 'master' into fix/ambassadors-card

2af74b6

priyanshuxkumar changed the title ~~fix: Misaligned Ambassador Bio Text in Cards~~ fix: misaligned ambassador bio text in cards Mar 8, 2025

akshatnema reviewed Mar 8, 2025

View reviewed changes

priyanshuxkumar and others added 3 commits March 9, 2025 11:49

Merge branch 'asyncapi:master' into fix/ambassadors-card

5dfb185

fix : replace mt-auto with justify-between for alignment

91a2d7d

Merge branch 'master' into fix/ambassadors-card

66f8fd5

anshgoyalevil approved these changes Mar 9, 2025

View reviewed changes

asyncapi-bot added the ready-to-merge label Mar 9, 2025

asyncapi-bot merged commit 73b8496 into asyncapi:master Mar 9, 2025
18 of 19 checks passed

This was referenced Mar 10, 2025

fix: remove Twitter link for ambassador without a Twitter account #3859

Closed

Fix: Conditional rendering for social links in Ambassadors section #3860

Closed

fix: enable conditional rendering of social media links in Ambassadors Page #3861

Open

priyanshuxkumar deleted the fix/ambassadors-card branch March 10, 2025 20:17

priyanshuxkumar restored the fix/ambassadors-card branch March 10, 2025 20:17

priyanshuxkumar deleted the fix/ambassadors-card branch March 10, 2025 20:23

priyanshuxkumar restored the fix/ambassadors-card branch March 10, 2025 20:23

priyanshuxkumar deleted the fix/ambassadors-card branch March 10, 2025 20:23

This was referenced Mar 22, 2025

fix: fix misaligned cards in ambassador list items on Ambassadors page #3945

Open

fix: align ambassador contribution cards properly #3954

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: misaligned ambassador bio text in cards #3848

fix: misaligned ambassador bio text in cards #3848

priyanshuxkumar commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

netlify bot commented Mar 8, 2025 •

edited

Loading

codecov bot commented Mar 8, 2025 •

edited

Loading

netlify bot commented Mar 8, 2025 •

edited

Loading

akshatnema Mar 8, 2025

priyanshuxkumar Mar 9, 2025

anshgoyalevil commented Mar 9, 2025

fix: misaligned ambassador bio text in cards #3848

fix: misaligned ambassador bio text in cards #3848

Conversation

priyanshuxkumar commented Mar 8, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 8, 2025 • edited Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

netlify bot commented Mar 8, 2025 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

codecov bot commented Mar 8, 2025 • edited Loading

Codecov Report

netlify bot commented Mar 8, 2025 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

akshatnema Mar 8, 2025

Choose a reason for hiding this comment

priyanshuxkumar Mar 9, 2025

Choose a reason for hiding this comment

anshgoyalevil commented Mar 9, 2025

priyanshuxkumar commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

netlify bot commented Mar 8, 2025 •

edited

Loading

codecov bot commented Mar 8, 2025 •

edited

Loading

netlify bot commented Mar 8, 2025 •

edited

Loading