Skip to content

Conversation

@asyncapi-bot
Copy link
Contributor

@asyncapi-bot asyncapi-bot commented Feb 16, 2025

Updated cli documentation is available and this PR introduces update to cli folder on the website

Summary by CodeRabbit

  • Documentation
    • Updated CLI usage instructions to simplify command signatures by removing proxy parameters.
    • Adjusted examples and descriptions for the convert, optimize, and validate commands to reflect the streamlined design.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2025

Walkthrough

The documentation for the AsyncAPI CLI usage has been updated to simplify the command signatures. Optional proxy parameters ([PROXYHOST] and [PROXYPORT]) have been removed from the asyncapi convert, asyncapi optimize, and asyncapi validate commands. Usage examples and descriptions have been revised to align with the new, streamlined syntax.

Changes

File(s) Change Summary
docs/.../cli/usage.md Removed optional proxy parameters from the command signatures of asyncapi convert, asyncapi optimize, and asyncapi validate; updated corresponding descriptions and examples.

Possibly related PRs

Suggested labels

autoapproved, autoupdate

Suggested reviewers

  • quetzalliwrites
  • VaishnaviNandakumar
  • Aahil13
  • TRohit20
  • asyncapi-bot-eve

Poem

I'm a happy rabbit with a hop in my stride,
Skipping through docs on a breezy ride.
No more proxies cluttering the command's view,
A simpler, clearer docs path anew!
With twitching whiskers and a joyful cheer,
I celebrate these changes far and near.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 8b6ac97
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67b192395905eb0008509e49
😎 Deploy Preview https://deploy-preview-3689--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (522cd2f) to head (8b6ac97).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3689   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asyncapi-bot asyncapi-bot merged commit 6b2fb0a into master Feb 16, 2025
32 of 34 checks passed
@asyncapi-bot asyncapi-bot deleted the update-cli-docs-67d7e8f206d71181a9c3ca93df1f38ed550ff22b branch February 16, 2025 07:26
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
markdown/docs/tools/cli/usage.md (3)

317-317: Fenced Code Block: Specify Language

The fenced code block starting at this line does not have a language specifier. Adding one (e.g. use ```sh instead of just ```) will improve readability and comply with markdownlint recommendations.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

317-317: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


663-663: Fenced Code Block: Add Language Identifier

Consider adding a language identifier to the fenced code block at this line. For instance, replacing the opening fence with ```sh can enhance syntax highlighting.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

663-663: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


767-767: Fenced Code Block: Include Language Tag

The fenced code block here would benefit from specifying a language (e.g. sh) to improve clarity and achieve better compliance with markdownlint rules.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

767-767: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 522cd2f and 8b6ac97.

📒 Files selected for processing (1)
  • markdown/docs/tools/cli/usage.md (5 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
markdown/docs/tools/cli/usage.md

317-317: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


663-663: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


767-767: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 180000ms (2)
  • GitHub Check: Automerge PR autoapproved by a bot
  • GitHub Check: Lighthouse CI
🔇 Additional comments (4)
markdown/docs/tools/cli/usage.md (4)

55-55: Updated Command Listing for asyncapi convert

The command listing now reads asyncapi convert [SPEC-FILE] which correctly removes the optional [PROXYHOST] and [PROXYPORT] parameters in line with the PR objectives. Please double-check that the detailed usage (the code block under the ## asyncapi convert [SPEC-FILE] section) is updated consistently.


65-65: Updated Command Listing for asyncapi optimize

The simplified signature asyncapi optimize [SPEC-FILE] now appears without proxy parameters, aligning with the intended changes. Verify that all examples and the detailed usage for this command (later in the document) reflect this update.


69-69: Updated Command Listing for asyncapi validate

The command listing has been revised to asyncapi validate [SPEC-FILE], removing the optional proxy settings. Ensure that the in-depth usage section and any examples also match this simplified signature.


763-764: Updated Command Header for asyncapi validate

The header for the validate command now shows asyncapi validate [SPEC-FILE], which is in line with the removal of proxy parameters. Please confirm that any internal references or auto-generated explanations no longer mention the proxy flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants