-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(cli): update latest cli documentation #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cli): update latest cli documentation #3551
Conversation
WalkthroughThis pull request introduces documentation updates for the AsyncAPI CLI, focusing on enhancing the documentation structure and adding new proxy-related functionality. A new architecture documentation file has been created to provide comprehensive insights into the CLI's structure and components. Additionally, several existing documentation files have had their metadata weights adjusted, and the usage documentation has been updated to include new proxy host and port flags for convert, optimize, and validate commands. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3551--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
markdown/docs/tools/cli/architecture.md (2)
15-70: Fix formatting inconsistencies in the directory structure section.There are multiple instances of loose punctuation marks in the bullet points. Consider standardizing the spacing after bullet points.
Apply consistent spacing in bullet points:
- - `config/`: Stores configuration-related files for commands. - `generate/`: Generates... + - `config/`: Stores configuration-related files for commands. + - `generate/`: Generates...🧰 Tools
🪛 LanguageTool
[uncategorized] ~21-~21: Loose punctuation mark.
Context: ...ated files for commands. -generate/: Generates typed models or other artifac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~24-~24: Loose punctuation mark.
Context: ...les using templates. -models.ts: Defines the models used during generati...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~25-~25: Loose punctuation mark.
Context: ...odels used during generation. -new/: Creates a new AsyncAPI file. - **Fi...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~28-~28: Loose punctuation mark.
Context: ...s file creation logic. -glee.ts: Related to Glee, a tool for event-drive...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~29-~29: Loose punctuation mark.
Context: ...ven microservices. -template.ts: Manages templates for new projects. -...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~30-~30: Loose punctuation mark.
Context: ...templates for new projects. -start/: Implements starting functionalities lik...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~36-~36: Loose punctuation mark.
Context: ...ir references together. -convert.ts: Converts AsyncAPI documents from older ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...n documents into AsyncAPI. -diff.ts: Compares two AsyncAPI documents. - `f...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~38-~38: Loose punctuation mark.
Context: ... two AsyncAPI documents. -format.ts: Converts AsyncAPI documents from any fo...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...to YAML, YML, or JSON. -optimize.ts: Optimizes AsyncAPI documents for perfor...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~40-~40: Loose punctuation mark.
Context: ...cuments for performance. -pretty.ts: Beautifies the AsyncAPI spec file (inde...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~41-~41: Loose punctuation mark.
Context: ...ed spec to a new file. -validate.ts: Validates AsyncAPI documents for correc...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~49-~49: Loose punctuation mark.
Context: ...tralized error definitions. -flags/: Defines CLI flags and their behavior. ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...I flags and their behavior. -hooks/: Event hooks used for customization. -...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~51-~51: Loose punctuation mark.
Context: ...ks used for customization. -models/: Core data models used across the applic...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...sed across the application. -utils/: Utility functions for common operations...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...ogic for CLI commands. -global.d.ts: Global TypeScript definitions. - `glo...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~57-~57: Loose punctuation mark.
Context: ...TypeScript definitions. -globals.ts: Stores global variables and configurati...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...bles and configurations. -parser.ts: Parses AsyncAPI documents. --- #### *...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ... data or files for testing. -hooks/: Tests related to hooks. - `integratio...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~67-~67: Loose punctuation mark.
Context: ...sts related to hooks. -integration/: Integration tests to verify end-to-end ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ... end-to-end functionality. -system/: System-level tests. -unit/: Unit t...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: Loose punctuation mark.
Context: ...ystem/: System-level tests. -unit/`: Unit tests for individual modules or fu...(UNLIKELY_OPENING_PUNCTUATION)
98-98: Enhance the conclusion with a more professional tone.Consider revising the concluding sentence to maintain a more professional documentation tone.
-This structure ensures the CLI is modular, scalable, and easy to maintain. Let me know if you need further clarification or additional details! +This structure ensures the CLI is modular, scalable, and easy to maintain. Please refer to the specific command documentation for detailed usage instructions.🧰 Tools
🪛 LanguageTool
[style] ~98-~98: This expression usually appears with a “please” in front of it.
Context: ...odular, scalable, and easy to maintain. Let me know if you need further clarification or ad...(INSERT_PLEASE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
markdown/docs/tools/cli/architecture.md(1 hunks)markdown/docs/tools/cli/context.md(1 hunks)markdown/docs/tools/cli/metrics_collection.md(1 hunks)markdown/docs/tools/cli/usage.md(7 hunks)
✅ Files skipped from review due to trivial changes (2)
- markdown/docs/tools/cli/metrics_collection.md
- markdown/docs/tools/cli/context.md
🧰 Additional context used
🪛 LanguageTool
markdown/docs/tools/cli/architecture.md
[uncategorized] ~21-~21: Loose punctuation mark.
Context: ...ated files for commands. - generate/: Generates typed models or other artifac...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~24-~24: Loose punctuation mark.
Context: ...les using templates. - models.ts: Defines the models used during generati...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~25-~25: Loose punctuation mark.
Context: ...odels used during generation. - new/: Creates a new AsyncAPI file. - **Fi...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~28-~28: Loose punctuation mark.
Context: ...s file creation logic. - glee.ts: Related to Glee, a tool for event-drive...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~29-~29: Loose punctuation mark.
Context: ...ven microservices. - template.ts: Manages templates for new projects. -...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~30-~30: Loose punctuation mark.
Context: ...templates for new projects. - start/: Implements starting functionalities lik...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~36-~36: Loose punctuation mark.
Context: ...ir references together. - convert.ts: Converts AsyncAPI documents from older ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...n documents into AsyncAPI. - diff.ts: Compares two AsyncAPI documents. - `f...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~38-~38: Loose punctuation mark.
Context: ... two AsyncAPI documents. - format.ts: Converts AsyncAPI documents from any fo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...to YAML, YML, or JSON. - optimize.ts: Optimizes AsyncAPI documents for perfor...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~40-~40: Loose punctuation mark.
Context: ...cuments for performance. - pretty.ts: Beautifies the AsyncAPI spec file (inde...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~41-~41: Loose punctuation mark.
Context: ...ed spec to a new file. - validate.ts: Validates AsyncAPI documents for correc...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~49-~49: Loose punctuation mark.
Context: ...tralized error definitions. - flags/: Defines CLI flags and their behavior. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...I flags and their behavior. - hooks/: Event hooks used for customization. -...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~51-~51: Loose punctuation mark.
Context: ...ks used for customization. - models/: Core data models used across the applic...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...sed across the application. - utils/: Utility functions for common operations...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...ogic for CLI commands. - global.d.ts: Global TypeScript definitions. - `glo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~57-~57: Loose punctuation mark.
Context: ...TypeScript definitions. - globals.ts: Stores global variables and configurati...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...bles and configurations. - parser.ts: Parses AsyncAPI documents. --- #### *...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ... data or files for testing. - hooks/: Tests related to hooks. - `integratio...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~67-~67: Loose punctuation mark.
Context: ...sts related to hooks. - integration/: Integration tests to verify end-to-end ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ... end-to-end functionality. - system/: System-level tests. - unit/: Unit t...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: Loose punctuation mark.
Context: ...ystem/: System-level tests. - unit/`: Unit tests for individual modules or fu...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~98-~98: This expression usually appears with a “please” in front of it.
Context: ...odular, scalable, and easy to maintain. Let me know if you need further clarification or ad...
(INSERT_PLEASE)
⏰ Context from checks skipped due to timeout of 180000ms (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
markdown/docs/tools/cli/usage.md (2)
3-3: LGTM! Documentation weight adjustment.The weight increase from 40 to 50 aligns with the broader documentation reorganization effort.
332-333: LGTM! Consistent proxy configuration documentation.The new proxy configuration flags (
--proxyHostand--proxyPort) are well-documented and consistently described across the convert, optimize, and validate commands.Also applies to: 720-721, 822-823
markdown/docs/tools/cli/architecture.md (1)
1-12: LGTM! Well-structured introduction.The metadata, introduction to oclif, and component overview provide a clear foundation for understanding the CLI architecture.
Updated cli documentation is available and this PR introduces update to cli folder on the website
Summary by CodeRabbit