[ty] Implement go-to for binary and unary operators #21001

MichaReiser · 2025-10-20T17:40:53Z

Summary

This PR implements goto and hover for binary operations and unary expressions.

As for other hover targets, the implementation doesn't try to match overloads yet.

This PR doesn't implement go-to support for augmented assign, which seems to match Pylance. I don't see a reason why we couldn't but I suggest leaving that for a separate PR

Fixes astral-sh/ty#1151

Test plan

Added tests

Screen.Recording.2025-10-21.at.13.21.23.mov

MichaReiser · 2025-10-21T10:12:57Z

crates/ty_ide/src/goto_definition.rs

        ");
    }

-    impl CursorTest {


I moved this to the end. It felt weird having it in the middle of the tests

github-actions · 2025-10-21T10:14:09Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

MichaReiser · 2025-10-21T10:14:23Z

crates/ty_python_semantic/src/types/ide_support.rs

+    let unary_dunder_method = match unary_op.op {
+        ast::UnaryOp::Invert => "__invert__",
+        ast::UnaryOp::UAdd => "__pos__",
+        ast::UnaryOp::USub => "__neg__",
+        ast::UnaryOp::Not => "__bool__",
+    };


It didn't feel worth pulling this out into its own Type method, especially because __bool__ is somewhat complicated when all we need here is to get the__bool__ dunder

You could possibly consider adding methods like these to the AST nodes directly, similar to what we already have for the bin-op nodes:

ruff/crates/ruff_python_ast/src/nodes.rs

Lines 2546 to 2602 in e1cada1

/// Returns the dunder method name for the operator.

pub const fn dunder(self) -> &'static str {

match self {

Operator::Add => "__add__",

Operator::Sub => "__sub__",

Operator::Mult => "__mul__",

Operator::MatMult => "__matmul__",

Operator::Div => "__truediv__",

Operator::Mod => "__mod__",

Operator::Pow => "__pow__",

Operator::LShift => "__lshift__",

Operator::RShift => "__rshift__",

Operator::BitOr => "__or__",

Operator::BitXor => "__xor__",

Operator::BitAnd => "__and__",

Operator::FloorDiv => "__floordiv__",

}

}

/// Returns the in-place dunder method name for the operator.

pub const fn in_place_dunder(self) -> &'static str {

match self {

Operator::Add => "__iadd__",

Operator::Sub => "__isub__",

Operator::Mult => "__imul__",

Operator::MatMult => "__imatmul__",

Operator::Div => "__itruediv__",

Operator::Mod => "__imod__",

Operator::Pow => "__ipow__",

Operator::LShift => "__ilshift__",

Operator::RShift => "__irshift__",

Operator::BitOr => "__ior__",

Operator::BitXor => "__ixor__",

Operator::BitAnd => "__iand__",

Operator::FloorDiv => "__ifloordiv__",

}

}

/// Returns the reflected dunder method name for the operator.

pub const fn reflected_dunder(self) -> &'static str {

match self {

Operator::Add => "__radd__",

Operator::Sub => "__rsub__",

Operator::Mult => "__rmul__",

Operator::MatMult => "__rmatmul__",

Operator::Div => "__rtruediv__",

Operator::Mod => "__rmod__",

Operator::Pow => "__rpow__",

Operator::LShift => "__rlshift__",

Operator::RShift => "__rrshift__",

Operator::BitOr => "__ror__",

Operator::BitXor => "__rxor__",

Operator::BitAnd => "__rand__",

Operator::FloorDiv => "__rfloordiv__",

}

}

}

But yeah, not is complicated because it falls back to __len__ as well as __bool__, even if you ignore all the fancy special casing we have baked in for the truthiness of various types.

github-actions · 2025-10-21T10:15:15Z

`mypy_primer` results

No ecosystem changes detected ✅
No memory usage changes detected ✅

MichaReiser · 2025-10-21T11:26:10Z

crates/ty_python_semantic/src/types/call.rs

+        // We either want to call lhs.__op__ or rhs.__rop__. The full decision tree from
+        // the Python spec [1] is:
+        //
+        //   - If rhs is a (proper) subclass of lhs, and it provides a different
+        //     implementation of __rop__, use that.
+        //   - Otherwise, if lhs implements __op__, use that.
+        //   - Otherwise, if lhs and rhs are different types, and rhs implements __rop__,
+        //     use that.
+        //
+        // [1] https://docs.python.org/3/reference/datamodel.html#object.__radd__


I extracted this from builder.rs. The lines are unchanged except that the map(|outcome| outcome.return_type()) remains in builder.rs

github-actions · 2025-10-21T12:13:21Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila

Looks good, thanks!

dhruvmanila · 2025-10-21T14:35:53Z

crates/ty_ide/src/goto.rs

+    if token.kind().is_comment() {
+        return None;
+    }


Just out of curiosity, is this to avoid returning Some when the cursor is inside a comment?

Short answer: yes :)

The problem with binary expressions and unary expressions is that we don't know the operator's range. That means, we would return Some for

( a + # comment<CURSOR> b )

Because the range is between a and b. But that's obviously not what we want.

AlexWaygood · 2025-10-21T16:04:26Z

One tiny UI nit (possibly not solvable, possibly playground-specific, just posting it because I noticed it):

If I have the cmd key held down and hover over a symbol, the symbol changes colour and becomes underlined, and my mouse symbol changes to a little ✋ to tell me that I can click on it to go to its definition. But the same thing doesn't happen if I have the cmd key held down and hover over an operator, so it's hard for me to tell that cmd-clicking on it is going to take me to the method being displayed by the on-hover tooltip. Here's a video in which I have the cmd key held down for the duration:

Screen.Recording.2025-10-21.at.16.59.41.mov

crates/ty_python_semantic/src/types/ide_support.rs

AlexWaygood

Really cool. The core logic looks great!

MichaReiser · 2025-10-21T16:27:54Z

If I have the cmd key held down and hover over a symbol, the symbol changes colour and becomes underlined, and my mouse symbol changes to a little ✋ to tell me that I can click on it to go to its definition. But the same thing doesn't happen if I have the cmd key held down and hover over an operator, so it's hard for me to tell that cmd-clicking on it is going to take me to the method being displayed by the on-hover tooltip. Here's a video in which I have the cmd key held down for the duration:

I noticed this too but it's not clear to me why it is happening, because we report the full range of the binary expression as its range. I can try to use a narrower range to see if that helps

MichaReiser · 2025-10-21T17:04:00Z

Nope, that doesn't help (but I think is strictly better). I did give r-a a try and it also doesn't underline + and other operands. We also correctly set the originSelectionRange but it seems VS code doesn't care?

It does work fine with not.

Confirmed, Zed renders this correctly

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* main: (65 commits) [ty] Some more simplifications when rendering constraint sets (#21009) [ty] Make `attributes.md` mdtests faster (#21030) [ty] Set `INSTA_FORCE_PASS` and `INSTA_OUTPUT` environment variables from mdtest.py (#21029) [ty] Fall back to `Divergent` for deeply nested specializations (#20988) [`ruff`] Autogenerate TypeParam nodes (#21028) [ty] Add assertions to ensure that we never call `KnownClass::Tuple.to_instance()` or similar (#21027) [`ruff`] Auto generate ast Pattern nodes (#21024) [`flake8-simplify`] Skip `SIM911` when unknown arguments are present (#20697) Render a diagnostic for syntax errors introduced in formatter tests (#21021) [ty] Support goto-definition on vendored typeshed stubs (#21020) [ty] Implement go-to for binary and unary operators (#21001) [ty] Avoid ever-growing default types (#20991) [syntax-errors] Name is parameter and global (#20426) [ty] Disable panicking mdtest (#21016) [ty] Fix completions at end of file (#20993) [ty] Fix out-of-order semantic token for function with regular argument after kwargs (#21013) [ty] Fix auto import for files with `from __future__` import (#20987) [`fastapi`] Handle ellipsis defaults in FAST002 autofix (`FAST002`) (#20810) [`ruff`] Skip autofix for keyword and `__debug__` path params (#20960) [`flake8-bugbear`] Skip `B905` and `B912` if <2 iterables and no starred arguments (#20998) ...

MichaReiser added server Related to the LSP server ty Multi-file analysis & type inference labels Oct 20, 2025

[ty] Implement go-to for binary and unary operators

c491e71

MichaReiser force-pushed the micha/unary-bin-op-goto branch from bc171df to c491e71 Compare October 21, 2025 10:11

MichaReiser commented Oct 21, 2025

View reviewed changes

Implement literal promotion

2cdaedf

MichaReiser commented Oct 21, 2025

View reviewed changes

MichaReiser marked this pull request as ready for review October 21, 2025 11:26

MichaReiser requested review from AlexWaygood, carljm, dcreager, dhruvmanila and sharkdp as code owners October 21, 2025 11:26

MichaReiser requested review from Gankra and removed request for carljm and dcreager October 21, 2025 11:44

Doctest

facf526

MichaReiser force-pushed the micha/unary-bin-op-goto branch from 9131141 to facf526 Compare October 21, 2025 11:56

dhruvmanila approved these changes Oct 21, 2025

View reviewed changes

AlexWaygood reviewed Oct 21, 2025

View reviewed changes

crates/ty_python_semantic/src/types/ide_support.rs Outdated Show resolved Hide resolved

AlexWaygood approved these changes Oct 21, 2025

View reviewed changes

MichaReiser and others added 2 commits October 21, 2025 19:08

Narrow range for bin and unary op

07144e0

Update crates/ty_python_semantic/src/types/ide_support.rs

e712106

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

MichaReiser merged commit 9d1ffd6 into main Oct 21, 2025
40 checks passed

MichaReiser deleted the micha/unary-bin-op-goto branch October 21, 2025 17:25

	/// Returns the dunder method name for the operator.
	pub const fn dunder(self) -> &'static str {
	match self {
	Operator::Add => "__add__",
	Operator::Sub => "__sub__",
	Operator::Mult => "__mul__",
	Operator::MatMult => "__matmul__",
	Operator::Div => "__truediv__",
	Operator::Mod => "__mod__",
	Operator::Pow => "__pow__",
	Operator::LShift => "__lshift__",
	Operator::RShift => "__rshift__",
	Operator::BitOr => "__or__",
	Operator::BitXor => "__xor__",
	Operator::BitAnd => "__and__",
	Operator::FloorDiv => "__floordiv__",
	}
	}

	/// Returns the in-place dunder method name for the operator.
	pub const fn in_place_dunder(self) -> &'static str {
	match self {
	Operator::Add => "__iadd__",
	Operator::Sub => "__isub__",
	Operator::Mult => "__imul__",
	Operator::MatMult => "__imatmul__",
	Operator::Div => "__itruediv__",
	Operator::Mod => "__imod__",
	Operator::Pow => "__ipow__",
	Operator::LShift => "__ilshift__",
	Operator::RShift => "__irshift__",
	Operator::BitOr => "__ior__",
	Operator::BitXor => "__ixor__",
	Operator::BitAnd => "__iand__",
	Operator::FloorDiv => "__ifloordiv__",
	}
	}

	/// Returns the reflected dunder method name for the operator.
	pub const fn reflected_dunder(self) -> &'static str {
	match self {
	Operator::Add => "__radd__",
	Operator::Sub => "__rsub__",
	Operator::Mult => "__rmul__",
	Operator::MatMult => "__rmatmul__",
	Operator::Div => "__rtruediv__",
	Operator::Mod => "__rmod__",
	Operator::Pow => "__rpow__",
	Operator::LShift => "__rlshift__",
	Operator::RShift => "__rrshift__",
	Operator::BitOr => "__ror__",
	Operator::BitXor => "__rxor__",
	Operator::BitAnd => "__rand__",
	Operator::FloorDiv => "__rfloordiv__",
	}
	}
	}

[ty] Implement go-to for binary and unary operators #21001

[ty] Implement go-to for binary and unary operators #21001

Uh oh!

Conversation

MichaReiser commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

MichaReiser Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

MichaReiser Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

MichaReiser Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

dhruvmanila left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvmanila Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood commented Oct 21, 2025

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

MichaReiser commented Oct 21, 2025

Uh oh!

MichaReiser commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MichaReiser commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

`mypy_primer` results

github-actions bot commented Oct 21, 2025 •

edited

Loading

`ruff-ecosystem` results

MichaReiser commented Oct 21, 2025 •

edited

Loading