[fastapi] Handle ellipsis defaults in FAST002 autofix (FAST002)
#20810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntBre
added
bug
ntBre
reviewed
Oct 15, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! This looks great. I just had a couple of small ideas/suggestions about the tests.
crates/ruff_linter/resources/test/fixtures/fastapi/FAST002_2.py
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/fastapi/FAST002_2.py
Outdated
Show resolved
Hide resolved
Contributor
|
It looks like the linux test failure was just a transient issue. The only real CI problem is the formatting. |
Contributor
Author
|
Thanks for the review! I’ll update it soon. |
…encies with Annotated types
ntBre
approved these changes
Oct 20, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! We just need to update one more minor thing in the snapshots.
I tried to push a commit, but GitHub said I didn't have permission. Sorry for the trouble!
ntBre
reviewed
Oct 20, 2025
...hots/ruff_linter__rules__fastapi__tests__fast-api-non-annotated-dependency_FAST002_2.py.snap
Outdated
Show resolved
Hide resolved
…in FAST002 tests snapshot
Contributor
|
dcreager
added a commit
that referenced
this pull request
Oct 22, 2025
* main: (65 commits) [ty] Some more simplifications when rendering constraint sets (#21009) [ty] Make `attributes.md` mdtests faster (#21030) [ty] Set `INSTA_FORCE_PASS` and `INSTA_OUTPUT` environment variables from mdtest.py (#21029) [ty] Fall back to `Divergent` for deeply nested specializations (#20988) [`ruff`] Autogenerate TypeParam nodes (#21028) [ty] Add assertions to ensure that we never call `KnownClass::Tuple.to_instance()` or similar (#21027) [`ruff`] Auto generate ast Pattern nodes (#21024) [`flake8-simplify`] Skip `SIM911` when unknown arguments are present (#20697) Render a diagnostic for syntax errors introduced in formatter tests (#21021) [ty] Support goto-definition on vendored typeshed stubs (#21020) [ty] Implement go-to for binary and unary operators (#21001) [ty] Avoid ever-growing default types (#20991) [syntax-errors] Name is parameter and global (#20426) [ty] Disable panicking mdtest (#21016) [ty] Fix completions at end of file (#20993) [ty] Fix out-of-order semantic token for function with regular argument after kwargs (#21013) [ty] Fix auto import for files with `from __future__` import (#20987) [`fastapi`] Handle ellipsis defaults in FAST002 autofix (`FAST002`) (#20810) [`ruff`] Skip autofix for keyword and `__debug__` path params (#20960) [`flake8-bugbear`] Skip `B905` and `B912` if <2 iterables and no starred arguments (#20998) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement handling of ellipsis (
...) defaults in theFAST002autofix to correctly differentiate between required and optional parameters in FastAPI route definitions.Previously, the autofix did not properly handle cases where parameters used
...as a default value (to indicate required parameters). This could lead to incorrect transformations when applying the autofix.This change updates the
FAST002autofix logic to:...as a valid FastAPI required default.Fixes #20800
Test Plan
Added a new test fixture at:
crates/ruff_linter/resources/test/fixtures/fastapi/FAST002_2.py