[pylint] Use lowercase hex characters to match the formatter (PLE2513)
#19808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLE2513 --fix changes ESC and SUB to uppercase hexadecimal values such as \x1B while the formatter changes them to lowercase \x1b
ember91
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
ntBre
approved these changes
Aug 7, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Looks good, thank you! And nice catch on the docs typo too. You just need to update a few more snapshots, and then this is good to go.
I'm also happy to push a commit for that if you prefer.
ntBre
changed the title
pylint] Use lowercase hex characters to match the formatter (PLE2513)
Contributor
Author
|
It's fine if you do. Thanks! |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLE2513 --fix changes ESC and SUB to uppercase hexadecimal values such as \x1B while the formatter changes them to lowercase \x1b
Summary
Test Plan