PLE2513 and format have different hex casing opinions

[ember91]

Summary

Minimal working example

Create a file with a string containing just the ASCII ESC character. For example like this in bash:

printf '"\x1b"\n' >file.py

Fix it:

ruff check --select PLE2513 --isolated ---fix file.py

It changed it to "\x1B" instead of ESC. Format it:

ruff format --isolated file.py

Now it's "\x1b"with a lowercase "b". I expected the checker and formatter to agree on the casing of the hexadecimal letters.

Version

0.12.7

[ntBre]

Oh, good catch. It looks like these are just hard-coded as capital letters in the fix replacement, so this should be as easy as swapping them to lowercase:

ruff/crates/ruff_linter/src/rules/pylint/rules/invalid_string_characters.rs

Lines 212 to 219 in 4d57fcd

	'\x1A' => (
	"\\x1A",
	context.report_diagnostic_if_enabled(InvalidCharacterSub, range),
	),
	'\x1B' => (
	"\\x1B",
	context.report_diagnostic_if_enabled(InvalidCharacterEsc, range),
	),

We don't always produce formatted fixes, but it seems a little silly not to in this case.

[ember91]

Seems like a good fix.

Thanks for an awesome piece of software I use almost every day!

[ember91]

I made a PR in #19808