[flake8-logging-format] Add auto-fix for f-string logging calls (G004)

[hamirmahal]

Closes #19302

Summary

This adds an auto-fix for Logging statement uses f-string Ruff G004, so users don't have to resolve it manually.

Test Plan

I ran the auto-fixes on a Python file locally and and it worked as expected.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +138 -0 fixes in 3 projects; 52 projects unchanged)

Snowflake-Labs/snowcli (+0 -0 violations, +4 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

- tests_integration/tests_using_container_services/spcs/docker/test_counter/simple_counter.py:37:21: G004 Logging statement uses f-string
+ tests_integration/tests_using_container_services/spcs/docker/test_counter/simple_counter.py:37:21: G004 [*] Logging statement uses f-string
- tests_integration/tests_using_container_services/spcs/docker/test_counter/simple_counter.py:39:17: G004 Logging statement uses f-string
+ tests_integration/tests_using_container_services/spcs/docker/test_counter/simple_counter.py:39:17: G004 [*] Logging statement uses f-string

apache/superset (+0 -0 violations, +120 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- superset/app.py:103:21: G004 Logging statement uses f-string
+ superset/app.py:103:21: G004 [*] Logging statement uses f-string
- superset/cli/examples.py:38:21: G004 Logging statement uses f-string
+ superset/cli/examples.py:38:21: G004 [*] Logging statement uses f-string
- superset/commands/database/uploaders/csv_reader.py:122:17: G004 Logging statement uses f-string
+ superset/commands/database/uploaders/csv_reader.py:122:17: G004 [*] Logging statement uses f-string
- superset/commands/theme/seed.py:104:26: G004 Logging statement uses f-string
+ superset/commands/theme/seed.py:104:26: G004 [*] Logging statement uses f-string
- superset/commands/theme/seed.py:96:26: G004 Logging statement uses f-string
+ superset/commands/theme/seed.py:96:26: G004 [*] Logging statement uses f-string
- superset/examples/bart_lines.py:62:18: G004 Logging statement uses f-string
+ superset/examples/bart_lines.py:62:18: G004 [*] Logging statement uses f-string
- superset/examples/birth_names.py:111:22: G004 Logging statement uses f-string
+ superset/examples/birth_names.py:111:22: G004 [*] Logging statement uses f-string
- superset/examples/multiformat_time_series.py:87:18: G004 Logging statement uses f-string
+ superset/examples/multiformat_time_series.py:87:18: G004 [*] Logging statement uses f-string
- superset/examples/paris.py:58:18: G004 Logging statement uses f-string
+ superset/examples/paris.py:58:18: G004 [*] Logging statement uses f-string
- superset/examples/random_time_series.py:71:18: G004 Logging statement uses f-string
+ superset/examples/random_time_series.py:71:18: G004 [*] Logging statement uses f-string
- superset/examples/sf_population_polygons.py:62:18: G004 Logging statement uses f-string
+ superset/examples/sf_population_polygons.py:62:18: G004 [*] Logging statement uses f-string
- superset/extensions/discovery.py:43:24: G004 Logging statement uses f-string
+ superset/extensions/discovery.py:43:24: G004 [*] Logging statement uses f-string
- superset/extensions/discovery.py:53:21: G004 Logging statement uses f-string
+ superset/extensions/discovery.py:53:21: G004 [*] Logging statement uses f-string
- superset/extensions/discovery.py:62:33: G004 Logging statement uses f-string
+ superset/extensions/discovery.py:62:33: G004 [*] Logging statement uses f-string
- superset/extensions/discovery.py:65:30: G004 Logging statement uses f-string
+ superset/extensions/discovery.py:65:30: G004 [*] Logging statement uses f-string
- superset/extensions/discovery.py:69:22: G004 Logging statement uses f-string
+ superset/extensions/discovery.py:69:22: G004 [*] Logging statement uses f-string
- superset/extensions/local_extensions_watcher.py:103:22: G004 Logging statement uses f-string
+ superset/extensions/local_extensions_watcher.py:103:22: G004 [*] Logging statement uses f-string
- superset/extensions/local_extensions_watcher.py:47:21: G004 Logging statement uses f-string
+ superset/extensions/local_extensions_watcher.py:47:21: G004 [*] Logging statement uses f-string
- superset/extensions/local_extensions_watcher.py:73:28: G004 Logging statement uses f-string
+ superset/extensions/local_extensions_watcher.py:73:28: G004 [*] Logging statement uses f-string
- superset/extensions/local_extensions_watcher.py:78:21: G004 Logging statement uses f-string
+ superset/extensions/local_extensions_watcher.py:78:21: G004 [*] Logging statement uses f-string
- superset/extensions/local_extensions_watcher.py:92:32: G004 Logging statement uses f-string
+ superset/extensions/local_extensions_watcher.py:92:32: G004 [*] Logging statement uses f-string
- superset/migrations/shared/catalogs.py:305:17: G004 Logging statement uses f-string
... 77 additional changes omitted for project

bokeh/bokeh (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- src/bokeh/application/handlers/directory.py:135:25: G004 Logging statement uses f-string
+ src/bokeh/application/handlers/directory.py:135:25: G004 [*] Logging statement uses f-string
- src/bokeh/application/handlers/document_lifecycle.py:66:25: G004 Logging statement uses f-string
+ src/bokeh/application/handlers/document_lifecycle.py:66:25: G004 [*] Logging statement uses f-string
- src/bokeh/io/notebook.py:581:19: G004 Logging statement uses f-string
+ src/bokeh/io/notebook.py:581:19: G004 [*] Logging statement uses f-string
- src/bokeh/io/notebook.py:582:19: G004 Logging statement uses f-string
+ src/bokeh/io/notebook.py:582:19: G004 [*] Logging statement uses f-string
- src/bokeh/io/state.py:176:22: G004 Logging statement uses f-string
+ src/bokeh/io/state.py:176:22: G004 [*] Logging statement uses f-string
... 4 additional changes omitted for project

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
G004	138	0	0	138	0

[MeGaGiGaGon]

How does this handle arbitrary format specs? Reading the code it looks to me like they all get converted to %s, which is definitely not ideal, and should at the very least make the fix unsafe/not offer a fix at all. As an example, what does the fix do on this code?

import logging
logging.info(f"{x:arbitrary data in format spec} {x:{'nested format spec'}}")

[ntBre]

Thanks for working on this! I think @MeGaGiGaGon raises some good points. I think it would make sense to bail out and not offer a fix if we see any complicated format specs, especially for a first iteration. We could keep the %d and %f handling that it looks like you already worked on, but I'd even be happy with only handling {var} -> %s in a first version (omitting format specs entirely).

I can try to give this a review next week if you resolve the conflicts :)

[hamirmahal]

You're welcome! That works for me. I pulled the latest changes and fixed the merge conflicts.

[ntBre]

Thanks! I had some organizational suggestions and also some edge cases I think we'll need to handle.

[hamirmahal]

You're welcome! Weekends are usually when I have more availability; I'll see if I can commit your suggestions now, though.

[ntBre]

Thanks, this is still looking good! Just a few more minor structural suggestions and another test idea. We still need to preview-gate this too. Let me know if you need help with that.

Apologies for the long delay in re-reviewing!

[ntBre]

Thank you again, this is very nearly ready. I mostly had very small performance-related nits and a suggestion on test placement. There's also one last edge case I came up with, but I think we can mostly delete code to solve it, which is always nice.

[ntBre]

Excellent, thanks again!

I went through the ecosystem changes, and they look good too. We don't show the suggested fix, but they all look like simple cases that I'd expect the fix to handle.

[hamirmahal]

You're welcome! Thanks for the suggestions and feedback.