[pyupgrade] Mark UP008 fix safe if no comments in range
#18683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ntBre
added
rule
Contributor
|
Could you resolve the merge conflicts here? Hopefully they're not too much trouble. |
Contributor
Author
|
@ntBre Done. Wasn't super straight-forward but manageable. Can you take a look so we can get it merged soon-ish before more conflicts arise? Thanks 🙇 |
ntBre
approved these changes
Jun 25, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Looks good, thanks! Just a couple of nits on the docs and another merge conflict, sorry!
crates/ruff_linter/src/rules/pyupgrade/rules/super_call_with_parameters.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>
ntBre
approved these changes
Jun 30, 2025
iyakushev
pushed a commit
to iyakushev/ruff
that referenced
this pull request
Jul 1, 2025
…h#18683) <!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Mark `UP008`'s fix safe if it won't delete comments. ## Relevant Issues Fixes: astral-sh#18533 --------- Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
UP008's fix safe if it won't delete comments.Relevant Issues
Fixes: #18533