Skip to content

Conversation

@kiran-4444
Copy link
Contributor

@kiran-4444 kiran-4444 commented May 16, 2025

Summary

Fixes astral-sh/ty#325

Currently, the base URL has been hardcoded. I'd appreciate a better way to do this.

Test Plan

Tested locally

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

mypy_primer results

No ecosystem changes detected ✅

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

Would you mind adding a small screenshot as test plan to the PR summary?

@MichaReiser MichaReiser added server Related to the LSP server ty Multi-file analysis & type inference diagnostics Related to reporting of diagnostics. labels May 16, 2025
@AlexWaygood AlexWaygood removed their request for review May 16, 2025 16:24
@MichaReiser MichaReiser enabled auto-merge (squash) May 17, 2025 17:23
@MichaReiser MichaReiser merged commit b86960f into astral-sh:main May 17, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics Related to reporting of diagnostics. server Related to the LSP server ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server: Add link to rule documentation

3 participants