Add a --release build to CI
#11182
Merged
Add a --release build to CI
#11182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/re
branch
from
8653346 to
dba3cdd
Compare
Contributor
|
zanieb
added a commit
that referenced
this pull request
Nov 20, 2024
This is one of the slowest remaining jobs in the pull request CI. We could use a larger runner for a trivial speed-up (in exchange for $$), but I don't think this is going to break often enough to merit testing on every pull request commit? It's not a required job, so I don't feel strongly about it, but it feels like a bit of a waste of compute. Originally added in #11182
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We merged a failure here (#11177), and it only takes ~five minutes anyway (which is shorter than some of our other jobs).