Remove `release` CI job #20887

MichaReiser · 2025-10-15T10:05:28Z

Summary

We added the release CI job to catch issues with conditionally compiled code (debug, cfg(debug_assertions) back in April 2024 (#11182).

But, we've since then also added cargo-test-linux-release (#14604), which not only compiles with the release profile but also runs all tests

ruff/.github/workflows/ci.yaml

Lines 300 to 331 in 3d2ece2

    
           cargo-test-linux-release: 
        
             name: "cargo test (linux, release)" 
        
             runs-on: depot-ubuntu-22.04-16 
        
             needs: determine_changes 
        
             if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }} 
        
             timeout-minutes: 20 
        
             steps: 
        
               - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 
        
                 with: 
        
                   persist-credentials: false 
        
               - uses: Swatinem/rust-cache@f13886b937689c021905a6b90929199931d60db1 # v2.8.1 
        
               - name: "Install Rust toolchain" 
        
                 run: rustup show 
        
               - name: "Install mold" 
        
                 uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1 
        
               - name: "Install cargo nextest" 
        
                 uses: taiki-e/install-action@522492a8c115f1b6d4d318581f09638e9442547b # v2.62.21 
        
                 with: 
        
                   tool: cargo-nextest 
        
               - name: "Install cargo insta" 
        
                 uses: taiki-e/install-action@522492a8c115f1b6d4d318581f09638e9442547b # v2.62.21 
        
                 with: 
        
                   tool: cargo-insta 
        
               - name: "Install uv" 
        
                 uses: astral-sh/setup-uv@d0cc045d04ccac9d8b7881df0226f9e82c39688e # v6.8.0 
        
                 with: 
        
                   enable-cache: "true" 
        
               - name: "Run tests" 
        
                 shell: bash 
        
                 env: 
        
                   NEXTEST_PROFILE: "ci" 
        
                 run: cargo insta test --release --all-features --unreferenced reject --test-runner nextest

That's why I think we can safely remove the release CI Job, as it's covered by cargo-test-linux-release

Test Plan

sharkdp · 2025-10-15T10:16:21Z

That's why I think we can safely remove the release CI Job, as it's covered by cargo-test-linux-release

Looks like the release job was running on macOS though, so we lose some coverage with this change. That might be acceptable if we have other macOS builds, though.

MichaReiser · 2025-10-15T10:22:42Z

Looks like the release job was running on macOS though, so we lose some coverage with this change. That might be acceptable if we have other macOS builds, though.

As far as I understand, the reason it ran on macOS was that those used to be the fastest runners available. We can introduce a new CI job that runs all tests on macos if we want, that should still be much cheaper than another release job

github-actions · 2025-10-15T10:42:53Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

AlexWaygood · 2025-10-15T11:56:28Z

.github/workflows/ci.yaml


+  cargo-test-macos:
+    name: "cargo test (macos)"
+    runs-on: depot-windows-2022-16


the MacOS job runs on Windows?

yes, it's faster that way

…rable * origin/main: [ty] Add (unused) `inferable` parameter to type property methods (#20865) Run macos tests on macos (#20889) Remove `release` CI job (#20887) [ty] CI: Faster ecosystem analysis (#20886) Remove `strip` from release profile (#20885) [ty] Sync vendored typeshed stubs (#20876) [ty] Add some completion ranking improvements (#20807) Improved error recovery for unclosed strings (including f- and t-strings) (#20848) Enable lto=fat (#20863) [`pyupgrade`] Extend `UP019` to detect `typing_extensions.Text` (`UP019`) (#20825) [`flake8-bugbear`] Omit annotation in preview fix for `B006` (#20877) fix(docs): Fix typo in `RUF015` description (#20873) [ty] Improve and extend tests for instance attributes redeclared in subclasses (#20866) [ty] Ignore slow seeds as a temporary measure (#20870) Remove parentheses around multiple exception types on Python 3.14+ (#20768) Update Black tests (#20794)

…nt-sets * dcreager/non-non-inferable: (174 commits) [ty] Add (unused) `inferable` parameter to type property methods (#20865) Run macos tests on macos (#20889) Remove `release` CI job (#20887) [ty] CI: Faster ecosystem analysis (#20886) Remove `strip` from release profile (#20885) [ty] Sync vendored typeshed stubs (#20876) [ty] Add some completion ranking improvements (#20807) Improved error recovery for unclosed strings (including f- and t-strings) (#20848) Enable lto=fat (#20863) [`pyupgrade`] Extend `UP019` to detect `typing_extensions.Text` (`UP019`) (#20825) [`flake8-bugbear`] Omit annotation in preview fix for `B006` (#20877) fix(docs): Fix typo in `RUF015` description (#20873) [ty] Improve and extend tests for instance attributes redeclared in subclasses (#20866) [ty] Ignore slow seeds as a temporary measure (#20870) use existing method Remove parentheses around multiple exception types on Python 3.14+ (#20768) Update Black tests (#20794) just the api parts [ty] Fix further issues in `super()` inference logic (#20843) [ty] Document when a rule was added (#20859) ...

MichaReiser added the ci Related to internal CI tooling label Oct 15, 2025

MichaReiser force-pushed the micha/larger-release-runner branch from 514ee9d to bdb0d03 Compare October 15, 2025 10:06

MichaReiser added the release Related to the release process label Oct 15, 2025

MichaReiser force-pushed the micha/larger-release-runner branch 2 times, most recently from ea8973d to 866e411 Compare October 15, 2025 10:08

MichaReiser changed the title ~~Use larger runner for release build~~ Use profile profiling for release CI check Oct 15, 2025

Remove release CI Job

3d2ece2

MichaReiser force-pushed the micha/larger-release-runner branch from 866e411 to 3d2ece2 Compare October 15, 2025 10:12

MichaReiser removed the release Related to the release process label Oct 15, 2025

MichaReiser changed the title ~~Use profile profiling for release CI check~~ Remove release CI job Oct 15, 2025

Add macos test CI job

284434a

sharkdp approved these changes Oct 15, 2025

View reviewed changes

MichaReiser merged commit c695938 into main Oct 15, 2025
37 checks passed

MichaReiser deleted the micha/larger-release-runner branch October 15, 2025 10:39

AlexWaygood reviewed Oct 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `release` CI job #20887

Remove `release` CI job #20887

Uh oh!

MichaReiser commented Oct 15, 2025 •

edited

Loading

Uh oh!

sharkdp commented Oct 15, 2025

Uh oh!

MichaReiser commented Oct 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

AlexWaygood Oct 15, 2025

Uh oh!

MichaReiser Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	cargo-test-linux-release:
	name: "cargo test (linux, release)"
	runs-on: depot-ubuntu-22.04-16
	needs: determine_changes
	if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' \|\| github.ref == 'refs/heads/main') }}
	timeout-minutes: 20
	steps:
	- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
	with:
	persist-credentials: false
	- uses: Swatinem/rust-cache@f13886b937689c021905a6b90929199931d60db1 # v2.8.1
	- name: "Install Rust toolchain"
	run: rustup show
	- name: "Install mold"
	uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
	- name: "Install cargo nextest"
	uses: taiki-e/install-action@522492a8c115f1b6d4d318581f09638e9442547b # v2.62.21
	with:
	tool: cargo-nextest
	- name: "Install cargo insta"
	uses: taiki-e/install-action@522492a8c115f1b6d4d318581f09638e9442547b # v2.62.21
	with:
	tool: cargo-insta
	- name: "Install uv"
	uses: astral-sh/setup-uv@d0cc045d04ccac9d8b7881df0226f9e82c39688e # v6.8.0
	with:
	enable-cache: "true"
	- name: "Run tests"
	shell: bash
	env:
	NEXTEST_PROFILE: "ci"
	run: cargo insta test --release --all-features --unreferenced reject --test-runner nextest

Remove release CI job #20887

Remove release CI job #20887

Uh oh!

Conversation

MichaReiser commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

sharkdp commented Oct 15, 2025

Uh oh!

MichaReiser commented Oct 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

AlexWaygood Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove `release` CI job #20887

Remove `release` CI job #20887

MichaReiser commented Oct 15, 2025 •

edited

Loading

`ruff-ecosystem` results