-
-
Notifications
You must be signed in to change notification settings - Fork 197
Update to 3.14.0b1 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 3.14.0b1 #610
Changes from all commits
a473674
88469ad
5a259c1
a1ace54
414e4a1
d081a85
b069848
c023f00
f5a7bac
4a5724d
d9f5072
04ad6e9
63f0d94
cff40b2
bca7d94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -466,7 +466,8 @@ if [ -n "${CPYTHON_OPTIMIZED}" ]; then | |
|
||
# Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently | ||
# using 10.15 as a miniumum version. | ||
if [ "${TARGET_TRIPLE}" != "x86_64-apple-darwin" ]; then | ||
# Do not enable when free-threading, because they're not compatible yet. | ||
if [[ ! ( "${TARGET_TRIPLE}" == "x86_64-apple-darwin" || -n "${CPYTHON_FREETHREADED}" ) ]]; then | ||
CONFIGURE_FLAGS="${CONFIGURE_FLAGS} --enable-experimental-jit=yes-off" | ||
fi | ||
|
||
|
@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$ | |
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k' | ||
fi | ||
|
||
# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | ||
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | ||
# in the comments, so just don't even try. (We should check if we can make this conditional) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @geofft can you open an issue to track this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #645. Let's add a link in this comment if we rework this PR. |
||
if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" ]]; then | ||
patch -p1 -i "${ROOT}/patch-python-configure-hacl-no-simd.patch" | ||
fi | ||
|
||
# We use ndbm on macOS and BerkeleyDB elsewhere. | ||
if [[ "${PYBUILD_PLATFORM}" = macos* ]]; then | ||
CONFIGURE_FLAGS="${CONFIGURE_FLAGS} --with-dbmliborder=ndbm" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ _blake2: | |
minimum-python-version: "3.14" | ||
- define: _DEFAULT_SOURCE | ||
minimum-python-version: "3.14" | ||
# Disable `explicit_bzero`, it requires glib 2.25+ | ||
# Disable `explicit_bzero`, it requires glibc 2.25+ | ||
- define: LINUX_NO_EXPLICIT_BZERO | ||
minimum-python-version: "3.14" | ||
|
||
|
@@ -88,6 +88,9 @@ _collections: | |
_contextvars: | ||
sources: | ||
- _contextvarsmodule.c | ||
config-c-only-conditional: | ||
- config-c-only: true | ||
minimum-python-version: "3.14" | ||
|
||
_crypt: | ||
maximum-python-version: "3.12" | ||
|
@@ -315,12 +318,6 @@ _hmac: | |
includes: | ||
- Modules/_hacl/ | ||
- Modules/_hacl/include/ | ||
links: | ||
- :libHacl_Hash_Blake2.a | ||
- :libHacl_Hash_SHA1.a | ||
- :libHacl_Hash_SHA2.a | ||
- :libHacl_Hash_SHA3.a | ||
- :libHacl_Hash_MD5.a | ||
defines: | ||
- _BSD_SOURCE | ||
- _DEFAULT_SOURCE | ||
|
@@ -376,7 +373,6 @@ _md5: | |
sources-conditional: | ||
- source: _hacl/Hacl_Hash_MD5.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
defines-conditional: | ||
- define: _BSD_SOURCE | ||
minimum-python-version: "3.12" | ||
|
@@ -435,6 +431,12 @@ _random: | |
sources: | ||
- _randommodule.c | ||
|
||
|
||
_remote_debugging: | ||
minimum-python-version: "3.14" | ||
sources: | ||
- _remote_debugging_module.c | ||
|
||
_scproxy: | ||
# _scproxy is Apple OS only. | ||
# APIs required by _scproxy not available on iOS. | ||
|
@@ -453,7 +455,6 @@ _sha1: | |
sources-conditional: | ||
- source: _hacl/Hacl_Hash_SHA1.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines-conditional: | ||
|
@@ -475,7 +476,6 @@ _sha2: | |
- sha2module.c | ||
sources-conditional: | ||
- source: _hacl/Hacl_Hash_SHA2.c | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines: | ||
|
@@ -491,7 +491,6 @@ _sha3: | |
minimum-python-version: "3.12" | ||
- source: _hacl/Hacl_Hash_SHA3.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines-conditional: | ||
|
@@ -617,6 +616,7 @@ _testcapi: | |
|
||
_testexternalinspection: | ||
minimum-python-version: '3.13' | ||
maximum-python-version: '3.13' | ||
sources: | ||
- _testexternalinspection.c | ||
|
||
|
@@ -645,6 +645,8 @@ _testinternalcapi: | |
minimum-python-version: "3.13" | ||
- source: _testinternalcapi/test_lock.c | ||
minimum-python-version: "3.13" | ||
- source: _testinternalcapi/complex.c | ||
minimum-python-version: "3.14" | ||
|
||
_testmultiphase: | ||
minimum-python-version: '3.9' | ||
|
@@ -769,6 +771,17 @@ _xxtestfuzz: | |
- _xxtestfuzz/_xxtestfuzz.c | ||
- _xxtestfuzz/fuzzer.c | ||
|
||
_zstd: | ||
# Disable on all targets until we add a zstd library | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to come before stable, I can open an issue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created #646 so we don't forget, feel free to edit/rephrase. |
||
disabled-targets: | ||
- .* | ||
minimum-python-version: '3.14' | ||
sources: | ||
- _zstd/_zstdmodule.c | ||
- _zstd/zdict.c | ||
- _zstd/compressor.c | ||
- _zstd/decompressor.c | ||
|
||
_zoneinfo: | ||
minimum-python-version: "3.9" | ||
sources: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we send this patch upstream for inclusion in 3.14? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a patch at python/cpython#134276 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
diff --git a/configure.ac b/configure.ac | ||
index a7b2f62579b..06c0c0c0da0 100644 | ||
--- a/configure.ac | ||
+++ b/configure.ac | ||
@@ -7897,8 +7897,7 @@ AC_SUBST([LIBHACL_LDFLAGS]) | ||
# The SIMD files use aligned_alloc, which is not available on older versions of | ||
# Android. | ||
# The *mmintrin.h headers are x86-family-specific, so can't be used on WASI. | ||
-if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \ | ||
- { test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; } | ||
+if false | ||
then | ||
dnl This can be extended here to detect e.g. Power8, which HACL* should also support. | ||
AX_CHECK_COMPILE_FLAG([-msse -msse2 -msse3 -msse4.1 -msse4.2],[ | ||
@@ -7930,8 +7929,7 @@ AC_SUBST([LIBHACL_BLAKE2_SIMD128_OBJS]) | ||
# Although AVX support is not guaranteed on Android | ||
# (https://developer.android.com/ndk/guides/abis#86-64), this is safe because we do a | ||
# runtime CPUID check. | ||
-if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \ | ||
- { test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; } | ||
+if false | ||
then | ||
AX_CHECK_COMPILE_FLAG([-mavx2],[ | ||
[LIBHACL_SIMD256_FLAGS="-mavx2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just "didn't work" in previous releases, now they made it a hard error.