Skip to content

Update to 3.14.0b1 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 4, 2025
Merged

Update to 3.14.0b1 #610

merged 15 commits into from
Jun 4, 2025

Conversation

@zanieb zanieb marked this pull request as draft May 17, 2025 02:13
@zanieb zanieb changed the title Update to 3.14b1 Update to 3.14.0b1 May 17, 2025
@zanieb
Copy link
Member Author

zanieb commented May 17, 2025

A couple new extension modules

2025-05-17T02:24:39.4965485Z Traceback (most recent call last):
2025-05-17T02:24:39.5035664Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 1307, in <module>
2025-05-17T02:24:39.5036416Z     sys.exit(main())
2025-05-17T02:24:39.5036632Z              ^^^^^^
2025-05-17T02:24:39.5037103Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 1289, in main
2025-05-17T02:24:39.5037637Z     build_cpython(
2025-05-17T02:24:39.5038102Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 764, in build_cpython
2025-05-17T02:24:39.5038589Z     setup = derive_setup_local(
2025-05-17T02:24:39.5038823Z             ^^^^^^^^^^^^^^^^^^^
2025-05-17T02:24:39.5039313Z   File "/home/runner/work/python-build-standalone/python-build-standalone/pythonbuild/cpython.py", line 388, in derive_setup_local
2025-05-17T02:24:39.5039811Z     raise Exception(
2025-05-17T02:24:39.5040120Z Exception: missing extension modules from YAML: _remote_debugging, _zstd

Base automatically changed from zb/14a7 to main May 17, 2025 03:37
@zanieb zanieb force-pushed the zb/14b1 branch 5 times, most recently from 8e5c165 to 185c89b Compare May 17, 2025 20:26
@zanieb
Copy link
Member Author

zanieb commented May 17, 2025

Alright, now we need to setup zstd

cpython-3.14> make: *** No rule to make target `Modules/_zstd/zdict.c', needed by `Modules/_zstd/zdict.o'.  Stop.
cpython-3.14> make: *** Waiting for unfinished jobs....
cpython-3.14> In file included from ./Modules/_zstd/_zstdmodule.c:10:
cpython-3.14> ./Modules/_zstd/_zstdmodule.h:11:10: fatal error: 'zstd.h' file not found
cpython-3.14>    11 | #include "zstd.h"
cpython-3.14>       |          ^~~~~~~~
cpython-3.14> 1 error generated.
cpython-3.14> make: *** [Modules/_zstd/_zstdmodule.o] Error 1
cpython-3.14> 1 warning generated.

@cclauss
Copy link

cclauss commented May 27, 2025

Beta 2: https://www.python.org/downloads/release/python-3140b2/

@geofft
Copy link
Collaborator

geofft commented May 30, 2025

Linux builds should hopefully be good now, if that validation change did what I expected.

Mac builds are failing because patch-jit-cflags-314.patch in #544 doesn't quite apply to b1 - Zanie, I'll let you handle that (and maybe you want to try b2 at the same time). If you rebase this branch on top of main, note that 867ca9c reverts fab9ad2, b01c183, and 856ce7e so personally I would ditch all four commits.

@zanieb
Copy link
Member Author

zanieb commented May 30, 2025

Thanks! I'll look at that patch

@zanieb
Copy link
Member Author

zanieb commented May 30, 2025

Windows failing due to some zstd stuff, e.g.:

cpython>          C:\Users\runneradmin\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\externals\zstd-1.5.7\lib\dictBuilder\cover.c(1,1): error C1083: Cannot open source file: 'C:\Users\runneradmin\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\externals\zstd-1.5.7\lib\dictBuilder\cover.c': No such file or directory [C:\Users\RUNNER~1\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\PCbuild\_zstd.vcxproj]

@@ -466,7 +466,8 @@ if [ -n "${CPYTHON_OPTIMIZED}" ]; then

# Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently
# using 10.15 as a miniumum version.
if [ "${TARGET_TRIPLE}" != "x86_64-apple-darwin" ]; then
# Do not enable when free-threading, because they're not compatible yet.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just "didn't work" in previous releases, now they made it a hard error.

@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k'
fi

# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL,
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted
# in the comments, so just don't even try. (We should check if we can make this conditional)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geofft can you open an issue to track this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#645. Let's add a link in this comment if we rework this PR.

@@ -769,6 +771,17 @@ _xxtestfuzz:
- _xxtestfuzz/_xxtestfuzz.c
- _xxtestfuzz/fuzzer.c

_zstd:
# Disable on all targets until we add a zstd library
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to come before stable, I can open an issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #646 so we don't forget, feel free to edit/rephrase.

Carol25170

This comment was marked as spam.

@zanieb zanieb marked this pull request as ready for review June 4, 2025 15:39
@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k'
fi

# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL,
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted
# in the comments, so just don't even try. (We should check if we can make this conditional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#645. Let's add a link in this comment if we rework this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we send this patch upstream for inclusion in 3.14?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a patch at python/cpython#134276

@zanieb zanieb merged commit d2030cb into main Jun 4, 2025
211 checks passed
@zanieb zanieb deleted the zb/14b1 branch June 4, 2025 16:20
@zanieb zanieb mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants