-
-
Notifications
You must be signed in to change notification settings - Fork 197
Update to 3.14.0b1 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 3.14.0b1 #610
Conversation
A couple new extension modules
|
8e5c165
to
185c89b
Compare
Alright, now we need to setup zstd
|
Linux builds should hopefully be good now, if that validation change did what I expected. Mac builds are failing because patch-jit-cflags-314.patch in #544 doesn't quite apply to b1 - Zanie, I'll let you handle that (and maybe you want to try b2 at the same time). If you rebase this branch on top of main, note that 867ca9c reverts fab9ad2, b01c183, and 856ce7e so personally I would ditch all four commits. |
Thanks! I'll look at that patch |
Windows failing due to some zstd stuff, e.g.:
|
@@ -466,7 +466,8 @@ if [ -n "${CPYTHON_OPTIMIZED}" ]; then | |||
|
|||
# Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently | |||
# using 10.15 as a miniumum version. | |||
if [ "${TARGET_TRIPLE}" != "x86_64-apple-darwin" ]; then | |||
# Do not enable when free-threading, because they're not compatible yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just "didn't work" in previous releases, now they made it a hard error.
@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$ | |||
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k' | |||
fi | |||
|
|||
# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | |||
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | |||
# in the comments, so just don't even try. (We should check if we can make this conditional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geofft can you open an issue to track this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#645. Let's add a link in this comment if we rework this PR.
@@ -769,6 +771,17 @@ _xxtestfuzz: | |||
- _xxtestfuzz/_xxtestfuzz.c | |||
- _xxtestfuzz/fuzzer.c | |||
|
|||
_zstd: | |||
# Disable on all targets until we add a zstd library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to come before stable, I can open an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #646 so we don't forget, feel free to edit/rephrase.
@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$ | |||
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k' | |||
fi | |||
|
|||
# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | |||
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | |||
# in the comments, so just don't even try. (We should check if we can make this conditional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#645. Let's add a link in this comment if we rework this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we send this patch upstream for inclusion in 3.14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a patch at python/cpython#134276
_zstd
bindings module python/cpython#133027_zstd
on Windows python/cpython#133366_remotedebugging
& rename to_remote_debugging
python/cpython#133398