Add TagHelperDescriptorResolver implementation. #148

NTaylorMullen · 2014-09-20T05:37:02Z

This involved also adding a TagHelperTypeResolver and TagHelperDescriptorFactory.
The TagHelperTypeResolver is responsible for determining the format of lookup text's used throughout the tag helper system. By default it handles the following formats:
"assemblyName"
"specificType, assemblyName"
It also restricts what types are considered TagHelpers. In this implementation we only accept public, non-nested, non-abstract, non-generic TagHelpers.
The TagHelperDescriptorFactory is responsible for converting a Type to a TagHelperDescriptor.
Added tests to validate TagHelperDescriptorResolver, TagHelperTypeResolver and TagHelperDescriptorFactory.
Tag Helpers: Create TagHelperDescriptor resolver system #99
Tag Helpers: Create string => Type[] resolver to indicate what Types are TagHelpers based on a lookup string.. #158

dougbu · 2014-09-27T23:23:11Z

src/Microsoft.AspNet.Razor.Runtime/Resources.resx

please remove this validation and file an issue for separate triage and tracking

Why? I feel like this definitely belongs in this PR. Part of the DescriptorResolver is verifying that TagHelpers do not conflict.

you're enlarging this PR to include a validation we may decide isn't needed in v1

your placement decisions are leading to an artificial feeling of size that in turn led to an artificial split between two resolution phases

even if we decide validation makes sense, it might make more sense as a part that's split out

dougbu · 2014-09-28T02:26:17Z

⌚
please remove test code from this design PR. just makes it seem more daunting.

NTaylorMullen · 2014-09-28T04:56:11Z

I didn't mean for this to be a full [Design] PR, it's just labeled [Design] because it hasnt been touched yet and we all had that offline discussion about labeling PR's as [Design] at first.

NTaylorMullen · 2014-09-29T01:18:19Z

Changed pretty much everything about this PR so I didn't bother with an "addressed code review comment" commit. Re-did the description of the PR and updated.

dougbu · 2014-10-03T17:04:10Z

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorResolver.cs

throw an ArgumentException instead, passing nameof(lookupText) to its constructor

dougbu · 2014-10-03T19:01:54Z

⌚ (very close)

NTaylorMullen · 2014-10-04T00:29:09Z

Addressed code review comments.

dougbu · 2014-10-04T05:30:37Z

src/Microsoft.AspNet.Razor/TagHelpers/TagHelperDescriptorComparer.cs

nit: one last "that is"

And "A" -> "An"

dougbu · 2014-10-04T05:44:40Z

- This involved also adding a TagHelperTypeResolver and TagHelperDescriptorFactory. - The TagHelperTypeResolver is responsible for determining the format of lookup text's used throughout the tag helper system. By default it handles the following formats: "assemblyName" "specificType, assemblyName" - It also restricts what types are considered TagHelpers. In this implementation we only accept public, non-nested, non-abstract, non-generic TagHelpers. - The TagHelperDescriptorFactory is responsible for converting a Type to a TagHelperDescriptor. - Added tests to validate TagHelperDescriptorResolver, TagHelperTypeResolver and TagHelperDescriptorFactory. #99 #158

- Tested the descriptor resolver and its underlying dependencies (TagHelperTypeResolver and TagHelperDescriptorFactory). #99 #158

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from c4efe4a to edc7da8 Compare September 20, 2014 06:09

NTaylorMullen changed the title ~~Add TagHelperDescriptorResolver implementation.~~ [Design] Add TagHelperDescriptorResolver implementation. Sep 20, 2014

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 4cd59eb to 68fd42a Compare September 23, 2014 06:47

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from edc7da8 to c3f3877 Compare September 23, 2014 06:47

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 68fd42a to 8ba1682 Compare September 24, 2014 00:11

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from c3f3877 to 7c7b97d Compare September 24, 2014 00:11

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 8ba1682 to 2f775d4 Compare September 25, 2014 07:07

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch 2 times, most recently from 208aaa7 to c729b8a Compare September 25, 2014 17:55

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 2f775d4 to 369a300 Compare September 25, 2014 23:20

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from c729b8a to 1d2d21e Compare September 25, 2014 23:20

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 369a300 to e9df146 Compare September 26, 2014 20:37

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch 3 times, most recently from 1f61154 to 437a2a5 Compare September 26, 2014 22:19

dougbu mentioned this pull request Sep 27, 2014

Create TagHelper specific C# code Generation. #134

Merged

dougbu reviewed Sep 27, 2014
View reviewed changes

dougbu mentioned this pull request Sep 28, 2014

[Design] Add TagHelperTypeResolver. #159

Closed

NTaylorMullen changed the title ~~[Design] Add TagHelperDescriptorResolver implementation.~~ Add TagHelperDescriptorResolver implementation. Sep 28, 2014

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from e9df146 to aff29a9 Compare September 29, 2014 01:15

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from 437a2a5 to 6ab43f5 Compare September 29, 2014 01:16

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from aff29a9 to 033cd96 Compare September 29, 2014 01:32

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from 6ab43f5 to 074916a Compare September 29, 2014 01:34

dougbu reviewed Oct 3, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from 8f2e2a2 to dd34a80 Compare October 4, 2014 00:27

dougbu reviewed Oct 4, 2014
View reviewed changes

NTaylorMullen added 2 commits October 4, 2014 11:36

Add tests to validate TagHelperDescriptorResolver.

268dde0

- Tested the descriptor resolver and its underlying dependencies (TagHelperTypeResolver and TagHelperDescriptorFactory). #99 #158

NTaylorMullen force-pushed the TagHelpers_AddDirective branch from 84f0011 to da3051a Compare October 4, 2014 19:52

NTaylorMullen force-pushed the TagHelpers_DescriptorResolver branch from dd34a80 to 268dde0 Compare October 4, 2014 19:52

NTaylorMullen closed this Oct 4, 2014

NTaylorMullen deleted the TagHelpers_DescriptorResolver branch October 20, 2014 18:06

Add TagHelperDescriptorResolver implementation. #148

Add TagHelperDescriptorResolver implementation. #148

Uh oh!

Conversation

NTaylorMullen commented Sep 20, 2014

Uh oh!

dougbu Sep 27, 2014

Choose a reason for hiding this comment

Uh oh!

NTaylorMullen Sep 28, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu Sep 28, 2014

Choose a reason for hiding this comment

Uh oh!

NTaylorMullen Sep 28, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu commented Sep 28, 2014

Uh oh!

NTaylorMullen commented Sep 28, 2014

Uh oh!

NTaylorMullen commented Sep 29, 2014

Uh oh!

dougbu Oct 3, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 3, 2014

Uh oh!

NTaylorMullen commented Oct 4, 2014

Uh oh!

dougbu Oct 4, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu Oct 4, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 4, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants