Create TagHelper specific C# code Generation. #134

NTaylorMullen · 2014-09-13T22:34:40Z

Added TagHelperChunk generation.
Added CSharp visitors to understand TagHelperChunk's and render corresponding C# code.
Refactored some code in the CSharpCodeVisitor so it could be utilized in other classes.
Tag Helpers: Create code generators and code visitors that understand tags #72

I split up the test portion of this PR to reduce noise. PR: #135

NTaylorMullen · 2014-09-13T22:36:53Z

src/Microsoft.AspNet.Razor/Generator/GeneratedTagHelperRenderingContext.cs

I left this class in flux because I'm aware I suck at naming 😄 . Therefore it's partially completed so i can address code review comments quicker. Feel free to comment on the / suggest better names

NTaylorMullen · 2014-09-15T21:58:32Z

src/Microsoft.AspNet.Razor/TagHelpers/TagHelperAttributeCodeGenerator.cs

We could make an interface for this if we want and have this be the default implementation. As @pranavkm and I discussed though it would probably be overkill.

dougbu · 2014-09-22T21:42:19Z

src/Microsoft.AspNet.Razor/Generator/Compiler/CodeBuilder/CSharp/CSharpCodeWriter.cs

excuse that rest of class is undocumented doesn't work for me here. when would instanceName be anything except this? why bother qualifying the method name with this.? if this method handles calls to methods on some other instance (not the current object), make that clear in the name and with comments.

It's never called for this., just for other instances, what would be a better name? Will add comment.

NTaylorMullen · 2014-09-23T06:49:12Z

Addressed comments in this PR.

dougbu · 2014-09-23T18:24:03Z

src/Microsoft.AspNet.Razor/Generator/GeneratedTagHelperRenderingContext.cs

suggest shortening to GeneratedTagHelperContext

dougbu · 2014-10-01T23:12:06Z

src/Microsoft.AspNet.Razor/Generator/TagHelperCodeGenerator.cs

any chance of null anywhere in this dereference chain? guard if so

Nope, when code is generated everything is initialized and the chunks automatically have a root object. 😄

pranavkm · 2014-10-02T03:58:57Z

src/Microsoft.AspNet.Razor/Generator/GeneratedClassContext.cs

Do [NotNull] instead

Will put [NotNull] just on this overload. Since all other overloads call into it 1 [NotNull] functionally works. As for an engineering guidelines standpoint I brought it up with @davidfowl because we should probably be consistent.

NTaylorMullen · 2014-10-02T06:12:12Z

Addressed code review comments.

pranavkm · 2014-10-02T16:33:02Z

src/Microsoft.AspNet.Razor/Generator/Compiler/CodeBuilder/CSharp/CSharpTagHelperCodeRenderer.cs

Do you need contentBehavior here?

Not anymore, good catch

NTaylorMullen · 2014-10-02T18:41:13Z

Addressed code review comments.

dougbu · 2014-10-02T19:33:42Z

src/Microsoft.AspNet.Razor/Generator/Compiler/CodeBuilder/CSharp/CSharpTagHelperCodeRenderer.cs

why isn't this restoration inside the finally block?

Because if something goes wrong recovering doesn't matter. As @pranavkm mentioned the Host is the only sensitive piece of information here that absolutely requires it to be set back. Will put it in the finally block anyways, doesn't hurt.

dougbu · 2014-10-02T22:23:31Z

after fixing last couple of XML and code comments

NTaylorMullen mentioned this pull request Sep 13, 2014

Add code generation tests for tag helpers. #135

Closed

NTaylorMullen reviewed Sep 13, 2014
View reviewed changes

NTaylorMullen changed the title ~~Create TagHelper specific C# code Generation.~~ [Design] Create TagHelper specific C# code Generation. Sep 14, 2014

NTaylorMullen reviewed Sep 15, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpersFeature branch from c431d3f to 6b646a0 Compare September 19, 2014 03:53

NTaylorMullen force-pushed the TagHelpers_CodeGeneration branch from df4136f to 7f3e80a Compare September 19, 2014 06:52

NTaylorMullen changed the title ~~[Design] Create TagHelper specific C# code Generation.~~ Create TagHelper specific C# code Generation. Sep 20, 2014

dougbu reviewed Sep 22, 2014
View reviewed changes

dougbu reviewed Sep 23, 2014
View reviewed changes

dougbu reviewed Oct 1, 2014
View reviewed changes

NTaylorMullen mentioned this pull request Oct 2, 2014

Discuss adding extensibility for the buffer result. #176

Closed

pranavkm reviewed Oct 2, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpersFeature branch from e9e03fb to dc3a520 Compare October 2, 2014 06:03

NTaylorMullen force-pushed the TagHelpers_CodeGeneration branch from a02e3a2 to 35855dd Compare October 2, 2014 06:03

pranavkm reviewed Oct 2, 2014
View reviewed changes

dougbu reviewed Oct 2, 2014
View reviewed changes

NTaylorMullen merged commit 0dac4a0 into TagHelpersFeature Oct 3, 2014

NTaylorMullen force-pushed the TagHelpers_CodeGeneration branch from e67684e to 0dac4a0 Compare October 3, 2014 08:04

NTaylorMullen deleted the TagHelpers_CodeGeneration branch October 3, 2014 08:10

Create TagHelper specific C# code Generation. #134

Create TagHelper specific C# code Generation. #134

Uh oh!

Conversation

NTaylorMullen commented Sep 13, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NTaylorMullen commented Sep 23, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NTaylorMullen commented Oct 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NTaylorMullen commented Oct 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 2, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants