Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use BASH_RLOCATION_FUNCTION from @aspect_bazel_lib in examples/js_binary/BUILD.bazel #1707

Merged
merged 1 commit into from
May 7, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented May 7, 2024

Pre-factor from #1690..

No reason to inline the # --- begin runfiles.bash initialization v2 --- when we can use the exported version from @aspect_bazel_lib.

@gregmagolan gregmagolan requested a review from jbedard May 7, 2024 05:22
@gregmagolan gregmagolan force-pushed the use_BASH_RLOCATION_FUNCTION branch from 2c9ecee to 5297f77 Compare May 7, 2024 05:24
Copy link

aspect-workflows bot commented May 7, 2024

Test

All tests were cache hits

211 tests (100.0%) were fully cached saving 42s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.


Test

e2e/gyp_no_install_script

All tests were cache hits

3 tests (100.0%) were fully cached saving 995ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 772ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 813ms.


Test

e2e/npm_translate_lock

All tests were cache hits

2 tests (100.0%) were fully cached saving 481ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 301ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 170ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 424ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

7 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 6s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 523ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 569ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 218ms.


Buildifier      Format

@gregmagolan gregmagolan force-pushed the use_BASH_RLOCATION_FUNCTION branch from 5297f77 to b57cbe2 Compare May 7, 2024 05:45
@gregmagolan gregmagolan requested a review from alexeagle May 7, 2024 05:46
@gregmagolan gregmagolan force-pushed the use_BASH_RLOCATION_FUNCTION branch from b57cbe2 to eb2121d Compare May 7, 2024 05:47
@gregmagolan gregmagolan requested a review from thesayyn May 7, 2024 06:07
@gregmagolan gregmagolan enabled auto-merge (squash) May 7, 2024 06:07
@jbedard jbedard disabled auto-merge May 7, 2024 06:49
Copy link
Member

@jbedard jbedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go into 1.x?

@gregmagolan
Copy link
Member Author

gregmagolan commented May 7, 2024

Can this go into 1.x?

Was going to say no because this depends on expand_template out of a newer bazel-lib... but looks like main is depending on a minimum bazel lib 1.42.3 which has expand_template already. I'll point it there instead.

@gregmagolan gregmagolan force-pushed the use_BASH_RLOCATION_FUNCTION branch from eb2121d to 38f9c1d Compare May 7, 2024 13:33
@gregmagolan gregmagolan changed the base branch from 2.x to main May 7, 2024 13:34
@gregmagolan gregmagolan force-pushed the use_BASH_RLOCATION_FUNCTION branch from 38f9c1d to 93b09ec Compare May 7, 2024 13:40
@gregmagolan gregmagolan merged commit bad68d5 into main May 7, 2024
103 checks passed
@gregmagolan gregmagolan deleted the use_BASH_RLOCATION_FUNCTION branch May 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants