-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use BASH_RLOCATION_FUNCTION from @aspect_bazel_lib in examples/js_binary/BUILD.bazel #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
use_BASH_RLOCATION_FUNCTION
branch
from
May 7, 2024 05:24
2c9ecee
to
5297f77
Compare
gregmagolan
force-pushed
the
use_BASH_RLOCATION_FUNCTION
branch
from
May 7, 2024 05:45
5297f77
to
b57cbe2
Compare
gregmagolan
force-pushed
the
use_BASH_RLOCATION_FUNCTION
branch
from
May 7, 2024 05:47
b57cbe2
to
eb2121d
Compare
jbedard
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this go into 1.x?
Was going to say no because this depends on expand_template out of a newer bazel-lib... but looks like main is depending on a minimum bazel lib 1.42.3 which has expand_template already. I'll point it there instead. |
gregmagolan
force-pushed
the
use_BASH_RLOCATION_FUNCTION
branch
from
May 7, 2024 13:33
eb2121d
to
38f9c1d
Compare
…les/js_binary/BUILD.bazel
gregmagolan
force-pushed
the
use_BASH_RLOCATION_FUNCTION
branch
from
May 7, 2024 13:40
38f9c1d
to
93b09ec
Compare
alexeagle
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-factor from #1690..
No reason to inline the
# --- begin runfiles.bash initialization v2 ---
when we can use the exported version from@aspect_bazel_lib
.