-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update js_binary executable path to {name}_/{name} #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
executable_path
branch
from
May 2, 2024 05:26
a7a18ea
to
60ba510
Compare
alexeagle
reviewed
May 2, 2024
gregmagolan
force-pushed
the
executable_path
branch
2 times, most recently
from
May 3, 2024 01:10
24d8cc1
to
4ce6045
Compare
Was this convention copied from somewhere? |
Copied from rules_go |
gregmagolan
force-pushed
the
executable_path
branch
7 times, most recently
from
May 3, 2024 05:50
8ac90e3
to
b6cff3c
Compare
gregmagolan
force-pushed
the
executable_path
branch
from
May 6, 2024 16:50
b6cff3c
to
47393f2
Compare
gregmagolan
force-pushed
the
executable_path
branch
2 times, most recently
from
May 6, 2024 21:05
3d289fd
to
d25cec7
Compare
gregmagolan
force-pushed
the
executable_path
branch
8 times, most recently
from
May 7, 2024 03:29
1937ccf
to
804e00e
Compare
gregmagolan
force-pushed
the
executable_path
branch
from
May 7, 2024 14:57
d4c87b2
to
0d71822
Compare
gregmagolan
force-pushed
the
executable_path
branch
2 times, most recently
from
May 7, 2024 15:29
d462667
to
85cdc18
Compare
gregmagolan
force-pushed
the
executable_path
branch
from
May 7, 2024 15:29
85cdc18
to
55c00e3
Compare
gregmagolan
force-pushed
the
2.x
branch
2 times, most recently
from
May 7, 2024 15:30
5058023
to
1001223
Compare
gregmagolan
force-pushed
the
executable_path
branch
from
May 7, 2024 15:31
55c00e3
to
baf8859
Compare
gregmagolan
force-pushed
the
executable_path
branch
from
May 7, 2024 21:17
baf8859
to
4493972
Compare
jbedard
approved these changes
May 7, 2024
gregmagolan
force-pushed
the
executable_path
branch
from
May 7, 2024 21:37
4493972
to
de6df66
Compare
jbedard
pushed a commit
that referenced
this pull request
May 8, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 13, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1586.
The trouble with the change in #1586 with the name of the executable in the output tree the same as the target name is that a target name such as
test
could be in a BUILD file where a subdirectory named test exists which can lead to build failures such as:This change resolves that issue without bringing back the
.sh
suffix that #1586 was addressing.NB: the
{name}_/{name}
naming scheme was copied from rules_go, which uses the same scheme forgo_binary
,