feat: add replace_packages to npm_translate_lock #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
force-pushed
the
inject_packages
branch
3 times, most recently
from
c10ea2e to
5e2fc5a
Compare
gregmagolan
force-pushed
the
inject_packages
branch
from
5e2fc5a to
bf28369
Compare
|
Internal slack link for reference: https://aspect-build.slack.com/archives/C05S94VJWNM/p1706724889343889 |
gregmagolan
added
customer request
gregmagolan
force-pushed
the
inject_packages
branch
4 times, most recently
from
e5631d5 to
ed84d9a
Compare
jbedard
reviewed
Feb 21, 2024
jbedard
approved these changes
Feb 21, 2024
gregmagolan
force-pushed
the
inject_packages
branch
from
ed84d9a to
1fe6096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritized feature request from an Aspect Workflows customer.
The use case is to be able to replace the npm package sources of an npm package as specified in the pnpm lock file with a custom npm_package target. The motivation for this feature is to allow users to replace non-hermetic lifecycle hooks in npm packages they depend on, such as node-gyp c++ compilation, with hermetic bazel targets. The feature, however, is generic so that it can be used for other use cases where a custom npm_package target to replace the sources specified in the pnpm lock file is useful.
Type of change
Test plan