Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Provide a way to overwrite existing npm dependency with a Bazel build target #1473

Closed
pyrocat101 opened this issue Feb 5, 2024 · 1 comment
Labels
customer request A request from a customer or potential customer enhancement New feature or request

Comments

@pyrocat101
Copy link

pyrocat101 commented Feb 5, 2024

What is the current behavior?

No response

Describe the feature

We have a number of npm dependencies that rely on the lifecycle scripts to build themselves using gyp. Instead of using gyp, we would like to build these packages using our own hermetic cc toolchain in Bazel. It would be great if there is a way to substitute a package in npm_translate_lock with a Bazel target.

Example hypothetical API to substitude node-re2 npm dependency with @node-re2 target:

npm_translate_lock(
  inject_packages = {
     "node-re2@*": "@node-re2//:node-re2"
  }
)
@pyrocat101 pyrocat101 added the enhancement New feature or request label Feb 5, 2024
@github-actions github-actions bot added the untriaged Requires traige label Feb 5, 2024
@gregmagolan gregmagolan added customer request A request from a customer or potential customer and removed untriaged Requires traige labels Feb 7, 2024
@gregmagolan
Copy link
Member

This is now supported with replace_packages in npm_translate_lock: #1481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request A request from a customer or potential customer enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants