feat: accept (version, integrity) for pnpm_version #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
approved these changes
Aug 2, 2023
alexeagle
force-pushed
the
i1173
branch
2 times, most recently
from
312ebb9 to
d286eb8
Compare
This allows users to choose a version we haven't vendored integrity hashes for.
alexeagle
added a commit
that referenced
this pull request
Aug 2, 2023
alexeagle
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to choose a version we haven't vendored integrity hashes for.
Fixes #1173
Type of change
For changes visible to end-users
Seems like we are missing docgen for
pnpm_repository.bzl- I'll add in a followup.Test plan
I changed the versions we use ourselves and tested that I can still run pnpm with/without bzlmod